slap nick

[Arnold_X-P]

I put together this TCL and it works fine, the issue is that the !slap nick (default) gets mixed up with the !slap nick phrase.

Code: Select all

set xphrases {
"\001ACTION full of slaps to <nicks> :-)"
"\001ACTION slaping :< and spitting in the face of <nicks> slapppppppppppp\001"
}

bind pub - !slap slapsnick
bind pub - ¡slap slapsnick
bind pub - .slap slapsnick

proc slapsnick {nick uhost hand chan arg} {
 global xphrases
 set target "[lindex [split $arg] 0]" ; set reason "[join [lrange [split $arg] 1 end]]"
 if {$arg == ""} { putserv "PRIVMSG $chan :\002The right thing\002 is \002!slap nick\002 example \002!slap sedition\002" ; return 0 }
 if {![onchan $target $chan]} { putserv "PRIVMSG $chan :$arg is not in $chan" -next ; return }
set slapsxp [lindex $xphrases [rand [llength $xphrases]]]
 regsub -all -- {<nicks>} $slapsxp $nick slapsxp
putserv "PRIVMSG $chan :$slapsxp $target $reason" -next
 } 

[CrazyCat]

Not sure to understand what you mean.
Can you give an example of the result of !slap nick and what you expected to have ?

[Arnold_X-P]

that the first command works well :

Code: Select all

[11:31] <nicolassss> !slap sedition
[11:31] * @Kantuta full of slaps to nicolassss :-) sedition 

It's in the second option slap, for example, !slap nickname phrase.
the right thing would be:

Code: Select all

[11:31] * @Kantuta full of slaps to sedition  :-) 

That's the detail; it blends in with the first slap.
[11:31] <nicolassss> !slap sedition wake up

Code: Select all

[11:31] * @Kantuta  slaping :< and spitting in the face of nicolassss slapppppppppppp sedition wake up

the right thing would be:

Code: Select all

[11:31] * @Kantuta  sedition wake up

[Arnold_X-P]

.slap nickname (works fine -- launches default phrases in set xphrases)
.slap nickname phrases ( bad --- It works, but it throws predefined phrases from xphrases and also throws custom phrases.)
In this last option, it should only launch the custom phrase
example :

Code: Select all

[11:31] <nicolassss> !slap sedition You're distracted
[11:31] * @Kantuta  sedition You're distracted

[CrazyCat]

Ok, so the trouble is that you don't check if $reason is set or not.
Here is a modified version of your script:

set xphrases {
   "\001ACTION full of slaps to <nicks> :-)"
   "\001ACTION slaping :< and spitting in the face of <nicks> slapppppppppppp\001"
}

bind pub - !slap slapsnick
bind pub - ¡slap slapsnick
bind pub - .slap slapsnick

proc slapsnick {nick uhost hand chan args} {
   global xphrases
   if {[llength $args] == 0} {
      putserv "PRIVMSG $chan :\002The right thing\002 is \002!slap nick\002 example \002!slap sedition\002"
      return
   }
   set target [join [lindex $args 0]]
   if {![onchan $target $chan]} {
      putserv "PRIVMSG $chan :$target is not in $chan"
      return
   }
   if {[llength $args] > 1} {
      set reason [join [lrange [split $args] 1 end]]
      putserv "PRIVMSG $chan :$target $reason"
   } else {
      set slapsxp [lindex $xphrases [rand [llength $xphrases]]]
      regsub -all -- {<nicks>} $slapsxp $nick slapsxp
      putserv "PRIVMSG $chan :$slapsxp"
   }
}

It also contains some little optimisations / arrangements to avoid warnings and errors

[Arnold_X-P]

I checked the code and it's fine, just as I requested.
But it's not working properly.

Code: Select all

<nicolassss> .slap
<@Kantuta >  is not in #curmmer

That's where I should launch this

Code: Select all

<nicolassss> .slap
@Kantuta The right thing is !slap nick example !slap sedition

and in this part of .slap nickname

Code: Select all

<nicolassss> .slap sedinne
* @Kantuta  slaping :< and spitting in the face of sedinne slapppppppppppp sedinne

It should only launch like this (default phrase from set xphrases)
it would be like this:

Code: Select all

* @Kantuta  slaping :< and spitting in the face of sedinne slapppppppppppp 

With the .slap nickname phrase option, this detail was observed: it indicates that the nickname is not in the channel.

Code: Select all

<nicolassss> .slap nicolassss don't sleep
<@Kantuta> nicolassss don't sleep is not in #curmmer

I don't know why the code is failing; it looks better organized and should work fine.

[CrazyCat]

I've corrected the last putserv (based on yours, so I didn't removed a $target which wasn't needed).
For others troubles... did you restart your eggdrop ?

And please, if you have errors, just write:

Code: Select all

<nicolassss> .slap
<@Kantuta >  is not in #curmmer

Code: Select all

<nicolassss> .slap
<@Kantuta > The right thing is !slap nick example !slap sedition

[CrazyCat]

Ok, the trouble is that $args has a count of 1 event if there is no arg (contains {})

So the first check must be:

   if {[string trim [join $args]] eq ""} {
      putserv "PRIVMSG $chan :\002The right thing\002 is \002!slap nick\002 example \002!slap sedition\002"
      return
   }

When the argument is just a nick, I understand what you want and it works.

But explain me what you expect to have when there is a reason.

[Arnold_X-P]

Code: Select all

set xphrases {
   "\001ACTION full of slaps to <nicks> :-)"
   "\001ACTION slaping :< and spitting in the face of <nicks> slapppppppppppp\001"
}

bind pub - !slap slapsnick
bind pub - ¡slap slapsnick
bind pub - .slap slapsnick

proc slapsnick {nick uhost hand chan args} {
   global xphrases
  if {[string trim [join $args]] eq ""} {
      putserv "PRIVMSG $chan :\002The right thing\002 is \002!slap nick\002 example \002!slap sedition\002"
      return
   }
   set target [join [lindex $args 0]]
   if {![onchan $target $chan]} {
      putserv "PRIVMSG $chan :$target is not in $chan"
      return
   }
   if {[llength $args] > 1} {
      set reason [join [lrange [split $args] 1 end]]
      putserv "PRIVMSG $chan :$target $reason"
   } else {
      set slapsxp [lindex $xphrases [rand [llength $xphrases]]]
      regsub -all -- {<nicks>} $slapsxp $nick slapsxp
      putserv "PRIVMSG $chan :$slapsxp"
   }
}

[Arnold_X-P]

Code: Select all

CrazyCat 
But explain me what you expect to have when there is a reason.

If there is a reason, state the reason of the person who threw it, for example:

Code: Select all

[11:31] <nicolassss> !slap sedition stop sleeping
[11:31] * @Kantuta stop sleeping sedition 

[Arnold_X-P]

After hours of trying, the issue with the `.slap` phrase was finally resolved. Here's the working TCL file... great work, CrazyCat! Thank you so much for the variations and for reorganizing the code.
I'm grateful to CrazyCat for the time and dedication they gave me when I requested assistance and help.

Code: Select all

`args` was replaced with `arg` in the variants.
And in `regsub -all -- {<nicks>} $slapsxp $nick slapsxp`, `$nick` was replaced with `$arg`, resulting in: `regsub -all -- {<nicks>} $slapsxp $arg slapsxp`.
And in the variant, `reason` was added to`\001ACTION slaps` to make it look like a real slap.

tcl resolved

Code: Select all

 set xphrases {
"\001ACTION slaping :< and spitting in the face of <nicks> slap's\001"
"<nicks> wake up, wake up"
"full of slaps, take take take <nicks>"
}

bind pub - !slap slapsnick
bind pub - ¡slap slapsnick
bind pub - .slap slapsnick

proc slapsnick {nick uhost hand chan arg} {
   global xphrases
 if {[string trim [join $arg]] eq ""} {
  putserv "PRIVMSG $chan :\002The right thing\002 is \002!slap nick\002 example \002!slap sedition\002"
  return
 }
 set target [join [lindex $arg 0]]
 if {![onchan $target $chan]} {
 putserv "PRIVMSG $chan :$target is not in $chan"
  return
  }
 if {[llength $arg] > 1} {
  set reason [join [lrange [split $arg] 1 end]]
  putserv "PRIVMSG $chan :\001ACTION slaps $target $reason\001" 
 } else {
 set slapsxp [lindex $xphrases [rand [llength $xphrases]]]
 regsub -all -- {<nicks>} $slapsxp $arg slapsxp
  putserv "PRIVMSG $chan :$slapsxp"
   }
}