Help me With editing this script !!

[Insectora]

With this script i kick chaters with public comand in the channel. When i add in the bot an user, and when he wants to kick me with the command
!kick Insectora ,the bot doesnt do this.Good. But the problem is when he wants to kick the bot with the command !kick Vees . And the bot kicks its self:((( And i don't want this off course ! Help me! What i should to edit to the script so the bot dont kick itself with the command !kick Vees ??


proc pub:kick {nick host hand chan text} {
set whom [lindex $text 0]
set reason [lrange $text 1 end]
if {[matchattr $whom f|f]} {return 0}
putserv "KICK $chan $whom :$reason"
putlog "#$hand# has kicked $whom from $chan"
}

[mortician]

well check if whom == botnick ...

Code: Select all

proc pub:kick {nick host hand chan text} {
global botnick
set whom [lindex $text 0] 
set reason [lrange $text 1 end] 
if {[matchattr $whom f|f] || $whom == $botnick} {return 0} 
putserv "KICK $chan $whom :$reason" 
putlog "#$hand# has kicked $whom from $chan" 
}

[caesar]

replace

Code: Select all

if {[matchattr $whom f|f]} {return 0}

with

Code: Select all

if {[matchattr $whom f|f] || $whom == $botnick} {return 0}

Also, you may want to do a chk if he is op first then continue with the kick and also a chk if is on channel. Replace:

Code: Select all

set whom [lindex $text 0]

with this:

Code: Select all

set whom [lindex $text 0]
if {![botisop $channel] || ![onchan $whom $chan]} { return }

[Insectora]

Sorry boys but doesn't work the edition you gave me:( The bot is still kicking itself with the command:(( !kick Vees .But why the script is not working well?
Any other commens??? pls help

[dvV]

do make sure it looks exactly like this to ensure you havent c/p something wrong...

Code: Select all

proc pub:kick {nick host hand chan text} { 
    global botnick 
    set whom [lindex $text 0] 
    if {![botisop $channel] || ![onchan $whom $chan]} { return } 
    set reason [lrange $text 1 end] 
    if {[matchattr $whom f|f] || $whom == $botnick} {return 0} 
    putserv "KICK $chan $whom :$reason" 
    putlog "#$hand# has kicked $whom from $chan" 
}

dvV

[caesar]

Well, is almost exactly I've sugested. Why don't you pay attention to the things I say?

[De Kus]

perhaps you need to check [string tolower $whom] == [string tolower $botnick]

[caesar]

Also a "[string tolower $chan]" will be nice..

[De Kus]

i dont think its necessary, cause the bot usally always has the chans in the same capitalation on it .
you only need the tolower check in nick this time, because if the bot sends KICK #chan VeEs, server kicks vees or Vees or any else, but if the bots nick is Vees VeEs == Vees will be untrue .

[egghead]

Additionally, about the script posted by dvV,

1. it uses a variable $channel without it being defined,
2. the [matchattr] lacks the $chan,
3. it uses [lindex] and [lrange] on a string (see Tcl FAQ 1).

[caesar]

Well, not exactly. Is the same thing as the nick. #cHaNnEl is not the same as #channel or #Channel or even #ChanneL. Do some tests and you will see what I'm talking about.

[egghead]

Well, not exactly. Is the same thing as the nick. #cHaNnEl is not the same as #channel or #Channel or even #ChanneL. Do some tests and you will see what I'm talking about.

What tests should be done to see what you are talking about?

[De Kus]

yeah, but this will probably NEVER become a problem, because the msg was send on exact that channel the bot should kick. so if the bot is on #Channel, $chan will never be #channel for the bot. it would be a diffrent if it is a bind on msg and not on pub .

[caesar]

So, finaly it should look like:

Code: Select all

proc pub:kick {nick host hand chan text} { 
  global botnick
  if {![llength $text] > 0 || ![botisop $chan]} { return }
  set whom [string tolower [lindex $text 0]]
  set chan [string tolower $chan]
  if {$whom == $botnick || [matchattr $whom f|f] || ![onchan $whom $chan]} { return }
  set reason [lrange $text 1 end] 
  putserv "KICK $chan $whom :$reason" 
  putlog "#$hand# has kicked $whom from $chan" 
}

[caesar]

A lil compare betwen #cHaNnEl and #channel even #Channel or #ChanneL. Or nevermind.. Some moron pissed me off a bit earlier and.. yah.. nevermind.