While....

BrollY · Post by **BrollY** » Mon May 12, 2003 3:54 pm

so far, in all my TCLs i use the 'foreach' function to read files n such, though ive come to scripting something that i believe that 'foreach' isnt doing the job properly. i tried to use the 'while' function to read files but i cant seem to get it to work how i want it to. how would i go about making it read a file, n how would i check each line? like in 'foreach' i would just call each line $line (foreach line $var {)

Post by **user** » Mon May 12, 2003 4:01 pm

Code: Select all

set f [open file r]
while {![eof $f]} {
    gets $f line
    # here's your $line...do what ever you like with it
}
close $f

in other words...

while {end of file is NOT reached} {get one line from the file and store the value in a variable called 'line'}

stdragon · Post by **stdragon** » Mon May 12, 2003 4:16 pm

In most circumstances, foreach is the best way. Using a while loop is more cumbersome because you have to check for eof after you read, not before. The code User posted doesn't do this, so you will end up processing an extra blank line in each file. The correct while loop code is like this:

Code: Select all

set file [open sheep/baa.txt r]
while {[gets $file line] != -1} {
  # $line holds the line read
}
close $file

Because Tcl is rather inefficient, if you are reading many lines it's much better to use foreach line [split [read $file] \n] like that. That makes tcl read all the lines at once using C code. For long files, it is *much* faster.

BrollY · Post by **BrollY** » Mon May 12, 2003 4:21 pm

im aware foreach is the better option n wat while does, but since foreach isnt properly doing wat i want, i gotta try the other choice

Post by **user** » Mon May 12, 2003 4:34 pm

what exactly is it that foreach isn't doing properly?

BrollY · Post by **BrollY** » Mon May 12, 2003 5:33 pm

its really hard to explain the real point of the tcl if u dont play a certain game, but ill give it a try.... somehow...

i just checked with some 'putlog' things to see if the bot gets stuck somewhere or something, n well, it reads a file it dls from a site, n with a command it searches the given parameters within the file. apparently, its not reading the first half of the file. i tried it with the 'while' function too, same result.

Post by **user** » Mon May 12, 2003 5:44 pm

This sounds weird. Have you verified that the file actually contains more data than what you're able to read/gets from it?

BrollY · Post by **BrollY** » Mon May 12, 2003 5:46 pm

ofc, downloaded it quite a few times already, i open it with wordpad over n over again n i can see the entire file n its just fine, but the bot itself wont read the first half

Post by **user** » Mon May 12, 2003 5:53 pm

Try 'fconfigure <file channel> -translation binary' before you read/gets from it.

BrollY · Post by **BrollY** » Mon May 12, 2003 5:55 pm

ehhhhh how would i go about doing that?

Post by **user** » Mon May 12, 2003 6:01 pm

something like

Code: Select all

set f [open file];# r is the default mode, so it's not needed
fconfigure $f -translation binary
set lines [split [read $f] \n]
...

BrollY · Post by **BrollY** » Mon May 12, 2003 8:07 pm

ok, tried it with the fconfigure thing n without it, n kept the putlog thing. the result is that it seems it does read the entire file, but it only starts doing the putlog thing after half the file has been read.

i honestly dont know wats wrong, n ive changed the coding many many many times over the past 4 days.

BrollY · Post by **BrollY** » Mon May 12, 2003 8:17 pm

nevermind, problem fixed
but thanks for the help