Couldn't count properly.

Stafford · Post by **Stafford** » Wed Dec 19, 2001 2:52 am

Hi, I've got this code and I hope someone could help me out with it.

if {($opmecom == "") && ([matchattr $hand omnpcbt]) || ([matchattr $hand omnpcbt $chan]) == 1 && ([string match #* $arg]) == 0} {
set copc 0
foreach c [channels] {
if {[onchan $nick $c] == 0} {
pushmode $c +o $nick
incr copc
}
}
puthelp "NOTICE $nick :** Opped you on $copc channels."

It works fine if the user is on all channels the eggdrop is in. However, if the user is not on 1 of the channel the eggdrop is in, the part "incr copc" couldn't count properly. It would give the 'puthelp' notice saying it had opped the user in (a number of channel) when the user uses the command even the user is not in the channel. Any ideas?

ppslim · Post by **ppslim** » Wed Dec 19, 2001 11:06 am

Move the puthelp command down one line, and add.

if {$copc} {

above it, and of course, the usual } below the puthelp.

Stafford · Post by **Stafford** » Wed Dec 19, 2001 11:59 pm

ppslim, it doesn't seems to fix the problem. When I add

if {$copc} {

There's no respond from the bot. It doesn't reply to the command used. However, if I remove

if {[onchan $nick $c]} {

It doesn't count properly again. Any ideas?

ppslim · Post by **ppslim** » Thu Dec 20, 2001 1:12 am

YUK - I juest noticed, that script is trying to OP the nick, only if he isn;t on the channel.

I won't dare write any code to replace it now, not until the drink wears off (yes, I'm drunk, you wanna make somthign of it)

Stafford · Post by **Stafford** » Thu Dec 20, 2001 7:04 am

Hehe. Ok, let's wait till you're "normal"

ppslim · Post by **ppslim** » Thu Dec 20, 2001 12:57 pm

if {($opmecom == "") && ([matchattr $hand omnpcbt]) || ([matchattr $hand omnpcbt $chan] == 1) && ([string match #* $arg] == 0)} {
set copc 0
foreach c [channels] {
if {[onchan $nick $c]} {
pushmode $c +o $nick
incr copc
}
}
if {$copc} {
puthelp "NOTICE $nick :** Opped you on $copc channels."
}
}

OK - A couple of issues after fixing this.

You should read up on what each global, and channel user flag is.

Matching against "omnpcbt" as the flags is not very secure. +t flag - This means that a botnet master (some1 witht he rights to link bots, not gain ops).

Note, you state, that the user should have either channel flags, or global flags to gain OPS in all channels. This means, that some1 who has been given channel OP's in one channel, can gain OP's in another channel, regardless of his flags.

jedis · Post by **jedis** » Thu Dec 20, 2001 9:27 pm

How would I modify this:

Code: Select all

#####.opall - op's you on all channels the bot is on

bind dcc o opall dcc_opall

proc dcc_opall {handle idx arg} {
set nick [lindex $arg 0]
if {$nick == ""} {
putlog "#$handle# opall"
putdcc $idx "[Faze.h] Please see [b].time opall[b]"
return 0
}
foreach ch [channels] {
putserv "MODE $ch +o $nick"
}
dccbroadcast "!dcc opall! $nick by $handle"
putlog "#$handle# opall $nick"
putlog "[Faze.n] Gave [b]op[b] to [b]$nick[b] on all channels."
return 0
}

So it only OP's a user if they do not already have OP's? As of now, it OP's the user in every channel they are in, regardless of whether or not they have OP's already.

Also, is there a way to add an if statement in there, so global +m can use the command on others, but global +o can only use it on themselves, regardless if they enter a nick or not? Right now, it works so any global op can use the command, and can enter any nickname to give anyone op's.

Thanks

Stafford · Post by **Stafford** » Fri Dec 21, 2001 4:04 am

Ok, so, which way do you recommend? By binding to - or (some|flags)?

Eh-heh.. regarding the incr copc, it doesn't seems to work at all. Any changes for that?

Thanks

<font size=-1>[ This Message was edited by: Stafford on 2001-12-21 06:05 ]</font>

Stafford · Post by **Stafford** » Sat Dec 22, 2001 2:38 am

ppslim, you missed out here?

ppslim · Post by **ppslim** » Sat Dec 22, 2001 9:01 pm

No, I just don;t spend 24 hours a day at the computerm, like so many people think.