Error Bass's Seen script. v1.4.2c

Zircon · Post by **Zircon** » Sun May 13, 2007 12:03 am

Hi all

I m having an error with bseen1.4.2.tcl. I m using this scripts for months now and it was working perfectly. Two hours ago i did .restart in the partyline, and the bot died with this error :

[22:37] bseen1.4.2c: -- Bass's SEEN loaded --
[22:37] Loading seen database...
[22:37] Tcl error in file 'zirc.conf':
[22:37] unmatched open brace in list
while executing
"lindex $inp 0"
(procedure "bs_read" line 27)
invoked from within
"bs_read"
invoked from within
"if {![info exists bs_list] || [array size bs_list] == 0} {putlog " Loading seen database..." ; bs_read}"
(file "scripts/bseen1.4.2.tcl" line 144)
invoked from within
"source scripts/bseen1.4.2.tcl"
(file "zirc.conf" line 1376)
[22:37] * CONFIG FILE NOT LOADED (NOT FOUND, OR ERROR)

When i erase the database of nicks, the bot starts fine, but whe i put it back, i have always this error. Does someone know the reason of this behavior and how to solve it ? i don't want to start a new database and lose the other one.

Thanks in advance

Post by **Sir_Fz** » Sun May 13, 2007 7:40 am

Here it is, the bot crashed due to misuse of list and string commands. [lindex] is being applied over $inp which is a string (apparently), replace

Code: Select all

lindex $inp 0

with

Code: Select all

lindex [split $inp] 0

and try loading it again.

Edit: corrected typo (imp should be inp)

Zircon · Post by **Zircon** » Sun May 13, 2007 10:14 am

Hello Sir_Fz

Thanks for the help. I did what u advised me, and replaced "lindex $inp 0" by "index [split $inp] 0" and then i loaded the script and restarted the bot. The bot didn't crash this time

i did !seen nickname, and it worked, althought when i made the seen with wildcards, like !seen nick*, i got this error in the partyline :

<Anti-Flood> [08:38] #Owner# set errorInfo
<Anti-Flood> Currently: unmatched open brace in list
<Anti-Flood> Currently: while executing
<Anti-Flood> Currently: "lindex $bs_list($item) 0"
<Anti-Flood> Currently: (procedure "bs_seenmask" line 21)
<Anti-Flood> Currently: invoked from within
<Anti-Flood> Currently: "bs_seenmask $chan $hand $args"
<Anti-Flood> Currently: (procedure "bs_pubreq" line 9)
<Anti-Flood> Currently: invoked from within
<Anti-Flood> Currently: "bs_pubreq $nick $uhost $hand $chan $args 1"
<Anti-Flood> Currently: (procedure "bs_pubreq2" line 1)
<Anti-Flood> Currently: invoked from within
<Anti-Flood> Currently: "bs_pubreq2 $_pub1 $_pub2 $_pub3 $_pub4 $_pub5"

So again i replaced in the script every "lindex $bs_list($item)" by "lindex [split $bs_list($item)]", and now it seems fully working.

Thanks very much for the help

Post by **Sir_Fz** » Sun May 13, 2007 4:50 pm

Bseen is a very popular script, it shouldn't contain such a vulnerability. Perhaps a new version with this fixed should be released?

cache · Post by **cache** » Sat May 26, 2007 10:49 pm

That's odd, works for me, latest version is 1.42c.

However log shows: [22:37] Tcl error in file 'zirc.conf': I would look in to that script, or temp remove it and try seen script again without the modifications, or start seen database from scratch, maybe one nick was listed corrupted it, who knows.

Zircon · Post by **Zircon** » Sun May 27, 2007 1:15 pm

Hi all

The script is working fine, but i m getting this error in the partyline :

<Anti-Flood> [12:01] Tcl error [bs_trim]: unmatched open brace in list

When i type .set errorinfo, i get this :

<Anti-Flood> [12:08] #Owner# set errorInfo
<Anti-Flood> Currently: unmatched open brace in list
<Anti-Flood> Currently: while executing
<Anti-Flood> Currently: "lindex $bs_list([string tolower $b]) 2"
<Anti-Flood> Currently: (procedure "bs_lsortcmd" line 1)
<Anti-Flood> Currently: invoked from within
<Anti-Flood> Currently: "bs_lsortcmd os|r|s labelle24"
<Anti-Flood> Currently: (-compare command)
<Anti-Flood> Currently: invoked from within
<Anti-Flood> Currently: "lsort -increasing -command bs_lsortcmd $list"
<Anti-Flood> Currently: (procedure "bs_trim" line 3)
<Anti-Flood> Currently: invoked from within
<Anti-Flood> Currently: "bs_trim $_time1 $_time2 $_time3 $_time4 $_time5"

I have to mention that os|r|s and labelle24 re nicks listed in the database.

Also, when i type .seenstats, i got :

<Anti-Flood> Currently I am tracking 6121/6000 nicks, which comprise 4470 unique uhosts. The oldest record is SANGLIER's, which is from 65 days, 23 hours, 5 minutes ago.

Since the size of the database is supposed to be 6000 nicks, how come i m having 6121 nicks ?

Can some1 explain the reason i m having this error in the partyline ?

Thank in advance

YooHoo · Post by **YooHoo** » Sun May 27, 2007 2:36 pm

bseen.tcl is a great piece of code, and there shouldn't be any errors in it. Maybe you might wanna try this: save the text files containing all the seen data, remove the tcl, then download a fresh copy. Maybe the errors will disappear like magic

Post by **Sir_Fz** » Sun May 27, 2007 7:57 pm

cache wrote:That's odd, works for me, latest version is 1.42c.

However log shows: [22:37] Tcl error in file 'zirc.conf': I would look in to that script, or temp remove it and try seen script again without the modifications, or start seen database from scratch, maybe one nick was listed corrupted it, who knows.

Zirc.conf is the name of his eggdrop configuration file and has nothing to do with the error (except for loading the script which has the bug).

Zircon wrote:Hi all

The script is working fine, but i m getting this error in the partyline :

<Anti-Flood> [12:01] Tcl error [bs_trim]: unmatched open brace in list

When i type .set errorinfo, i get this :

<Anti-Flood> [12:08] #Owner# set errorInfo
<Anti-Flood> Currently: unmatched open brace in list
<Anti-Flood> Currently: while executing
<Anti-Flood> Currently: "lindex $bs_list([string tolower $b]) 2"
<Anti-Flood> Currently: (procedure "bs_lsortcmd" line 1)
<Anti-Flood> Currently: invoked from within
<Anti-Flood> Currently: "bs_lsortcmd os|r|s labelle24"
<Anti-Flood> Currently: (-compare command)
<Anti-Flood> Currently: invoked from within
<Anti-Flood> Currently: "lsort -increasing -command bs_lsortcmd $list"
<Anti-Flood> Currently: (procedure "bs_trim" line 3)
<Anti-Flood> Currently: invoked from within
<Anti-Flood> Currently: "bs_trim $_time1 $_time2 $_time3 $_time4 $_time5"

I have to mention that os|r|s and labelle24 re nicks listed in the database.

Same problem, replace lindex $bs_list([string tolower $b]) 2 with lindex [split $bs_list([string tolower $b])] 2

Edit: You might want to [split] all occurrences of $bs_list in the script.

YooHoo wrote:bseen.tcl is a great piece of code, and there shouldn't be any errors in it. Maybe you might wanna try this: save the text files containing all the seen data, remove the tcl, then download a fresh copy. Maybe the errors will disappear like magic

It is a fine piece of code in deed, but it still has the vulnerability of applying list-commands over strings.

Zircon · Post by **Zircon** » Mon May 28, 2007 1:12 am

Hello Sir_Fz

U were right from the beginning, i did what u advised me, and now i m not having anymore errors in the partyline ! Once again, u find the solution in no time, thanks very much !

Also, now when i make .seenstats in the party line, i get the right answer, unlike before. Now i m having this :

<Anti-Flood> Currently I am tracking 6000/6000 nicks, which comprise 4386 unique uhosts. The oldest record is TALAL7's, which is from 64 days, 2 hours, 37 minutes ago.

Whick is correct

Before, it was saying : <Anti-Flood> Currently I am tracking 6121/6000 nicks...etc

THANKS VERY MUCH

Domin · Post by **Domin** » Mon Jun 11, 2007 3:34 pm

Sir_Fz wrote:Here it is, the bot crashed due to misuse of list and string commands. [lindex] is being applied over $inp which is a string (apparently), replace
Code: Select all
lindex $imp 0
with
Code: Select all
lindex [split $imp] 0
and try loading it again.

The nearest match i can find to this line is:

lindex [split $inp] 0

Thats an n and not an m in that line, just for the noobs like me that spend a long time looking for the other line

Zircon · Post by **Zircon** » Mon Jun 11, 2007 4:42 pm

Hello Domin

My fault, i knew that that Sir_Fz meant $inp insted fo $imp, i corrected in my copy of bseen, but forgot to report it here, sorry.

By the way, all the problems that appeared when the database reached the maximum of nicks specied in bseen.tcl, all these problems are solved when i followed the suggestions of Sir_Fz. Big Thanks to him

Domin · Post by **Domin** » Mon Jun 11, 2007 4:55 pm

Yupp, he does great work

I also corrected my bot with all settings posted here, but i am wondering how my bot gets over 11000 lines in the datafile to this:

[21:36:08] <@MMonitor> Currently I am tracking 506/1500000 nicks, which comprise 454 unique uhosts. The oldest record is Coldie^St's, which is from 316 days, 2 hours, 4 minutes ago.

and then when i ran the same command a few hours later:

[22:51:28] <@MMonitor> Currently I am tracking 536/1500000 nicks, which comprise 479 unique uhosts. The oldest record is Coldie^St's, which is from 316 days, 3 hours, 20 minutes ago.

seems rather strange but perhaps im best off starting on a fresh data file :-/

Post by **Sir_Fz** » Mon Jun 11, 2007 6:43 pm

I've edited my post above and fixed the typo