XE.com currency convertor script v0.02b

[Bonnie]

Thank you very much.
That cleared it up very nicely
Thanks again
Bonnie

[romeo5k]

The problem is he has 'junk' before the #comment in the very first top line. Interpreter sees that and hits the panic button and freaks out causing all this. Removing said 'junk' will solve it.

I thought the same, but nah its not.... there is nothing on the top line at alll!!!.....
I just noticed something tho, i went ahead and just used the script as is without changing anyhing, and voila, the bot joined the channel, So between me chaning the name and deleteing the other channels like #mychan2 and #etc, something is wrong there.. Ill seee if i can solve this fender bender myself!
<<<<moments later>>>>>>

Rosc2112i figured it out... for some reason, when i try to

Code: Select all

bind pub - !curr xepub
bind msg - !curr xemsg

it gives me that funny looking error, so my bot wont start. What am i doing wrong?


<<<<minutes later>>>>
This is weird... i cant do anything... If i edit one thing i get the error, if i add my channel name and delte the others, i get an error. If i change the output from XE.COM to Currency, i get error. Ask me why, i dont know.
rosc2112, may i email you so u may help me. Because i dont know if maybe im doing something wrong. Unlless we wanna start talking about UTF-8 and stuff like that, and that gets into too much depth for me. I just wanna change a couple of things

[speechles]

the problem is your editor, which I assume your using notepad instead of wordpad which is a no-no, is obviously converting your tcl to something other than raw .txt . Try using an IDE such as ConText (http://www.context.cx/) to edit your script with.

[rosc2112]

1) Dont post screenshots, just post the error and preferably the output of .set errorInfo, read the FAQ about how to get useful info from .set errorInfo if you don't have "set" enabled.

2) The error you posted has nothing to do with my script.

3) There's also a faq about how to load scripts so they wont crash your bot and instead show useful debug/set errorInfo..

[nsrafk]

Hey rosc. Awesome script! I've a request though. I've seen another bot somewhere where output is different. I'd like to be able to change it into that layout.

Layout of the other bot:
USD->DKK 5.53820 (781 USD = 4325 DKK)

Compared to your script:
XE.COM: 781.00 USD equals 4,325.12 DKK as of 2007.06.04 04:39:32 UTC

I like the other layout because its much more simple. Would be nice if you could add some variables to set another layout. Im having this in mind:

$ex_rate (current exchange rate)
$amount_from (...)
$amount_to (...)
$curr_from (from currency)
$curr_to (to currency)

Would be very cool!

Thanks!

[rosc2112]

That alternative format makes no sense to me. If you want to know the value of 1, then input 1.

Feel free to hack on the script to suit yourself tho, I have no interest in such a modification. Give credit if you release a revision.

[nsrafk]

I dont know anything about tcl, so i cant modify it. That's why i posted in here hehe

[rosc2112]

not hard to learn if you're motivated.. I learned tcl in a few weeks.

[rosc2112]

Just a quick fix to remove xe.com's suddenly-anal garbage messages embedded in their data..

Same url as above.

[stobeh]

looks like xe.com has changed something and the script no longer works

EDIT:
works with the following switch in the script:
&& [regexp {<td width="45%" align="right" id="XEenlarge"><h2 class="XE">(.*?)</h2></td>} $html match fromamount] \
&& [regexp {<td width="45%" align="left" id="XEenlarge"><h2 class="XE">(.*?)</h2></td>} $html match toamount]} {

to

&& [regexp {<td width="45%" align="right" class="XEenlarge"><h2 class="XE">(.*?)</h2></td>} $html match fromamount] \
&& [regexp {<td width="45%" align="left" class="XEenlarge"><h2 class="XE">(.*?)</h2></td>} $html match toamount]} {

[rosc2112]

Thanks for the heads up. I'll upload a fixed version to the url above, everyone else can just edit and incorporate the fix you posted

[shahrul]

Hi,

today i got this error.

Could not obtain results from XE.com, sorry!

is there anything change?

[aa]

I am having the same problem and have been unable to figure out what has changed.

[speechles]

<speechles> !webby http://www.xe.com/ucc/convert.cgi?Amoun ... EUR&To=USD --regexp <title>.*?rate\:\s+(.*?)\s+=\s+(.*?)</title>--
<sp33chy> webby: conflict! http-package reports: iso8859-1 .. using charset detected from html meta tagging: utf-8 to avoid conflict.
<sp33chy> regexp: capture1 ( 1.00 EUR )
<sp33chy> regexp: capture2 ( 1.44060 USD )

Change this part:

Code: Select all

	if {[regexp {>Live rates at (.*?)</span>} $html match xetime] \
	&& [regexp {<td width="45%" align="right" class="XEenlarge"><h2 class="XE">(.*?)</h2></td>} $html match fromamount] \
	&& [regexp {<td width="45%" align="left" class="XEenlarge"><h2 class="XE">(.*?)</h2></td>} $html match toamount]} {
		regsub -all {<!.*?>} $fromamount {} fromamount
		regsub -all {<!.*?>} $toamount {} toamount
		puthelp "PRIVMSG $chan :XE.COM: \002$fromamount\002 equals \002$toamount\002 as of $xetime"
	} else {
		puthelp "PRIVMSG $chan :Could not obtain results from XE.com, sorry!"
	}

To make this really simple, and less likely to break in the future this scrapes the results from the title tag. So change the above to look like this:

Code: Select all

	if {[regexp {>Live rates at (.*?)</span>} $html match xetime] && [regexp --nocase {<title>.*?rate\:\s+(.*?)\s+=\s+(.*?)</title>} $html match fromamount toamount]} {
		puthelp "PRIVMSG $chan :XE.COM: \002$fromamount\002 equals \002$toamount\002 as of $xetime"
	} else {
		puthelp "PRIVMSG $chan :Could not obtain results from XE.com, sorry!"
	}

[shahrul]

Hi,

I got this problem after changing the code.

Code: Select all

Tcl error [xepub]: syntax error in expression "[regexp {>Live rates at (.*?)</span>} $html match xetime] \ ...": extra tokens at end of expression