DragnLord's weather script

DragnLord · Post by **DragnLord** » Sun Sep 27, 2009 11:29 pm

Kein wrote:Also, help-string still says "[23:27:09] -Bot- Check your syntax, use .wz -help", but well, you see, I have changed the prefix and cmd... Just make it variable in help-text

Yes, that is an error, it should be "$weather help" for you.

Help is activated by using "help" as the location, I'll change the message for the next version.

DragnLord · Post by **DragnLord** » Sun Sep 27, 2009 11:47 pm

The country code is required for all locations outside of the United States of America.

DragnLord · Post by **DragnLord** » Mon Sep 28, 2009 12:14 am

Kein wrote: [country] -> I always thought that the args in [] brackets is optional.

[23:18:01] <Kein> $weather boston
[23:22:34] <Bot> [22:22] Tcl error [pub_wz]: can't read "outtitle": no such variable
Looks like I was wrong all my life.

Specifying the state with a city is not in [] brackets and is required as stated.
Country code for locations within the United States of America used to be optional, and now is not used.

speechles · Post by **speechles** » Mon Sep 28, 2009 5:33 pm

Actually, I think what he meant is the reason you require the state is because without it you are presented with a list of possible matches rather than a definite match.

CtrlAltDel wrote:
[23:18:01] <Kein> $weather boston
[23:22:34] <Bot> [22:22] Tcl error [pub_wz]: can't read "outtitle": no such variable
Looks like I was wrong all my life.

Can you just make it... optional? Let it return the first result, c'mon. It will not break anything or destroy the eternity.

He would rather it just take the top suggested result and roll with that than give a tcl error mentioning some non-existant variable, "outtitle". Or, at the very least, present the potential list of matches and ask for refinement. I don't think guy was asking for the moon, or your first born child. That makes damn good sense. You should embrace the ideas coming from people using your script, rather than impose your disdain upon them. And yeah, lighten up. It's only irc, type /clear. Breathe. ;D

Edit:

Code: Select all

find this:	
regexp {<title>(.*?)</title>} $html match outtitle
if {[string first Search $outtitle] !=-1} {puthelp "NOTICE $nick :Check your syntax, use .wz -help";close $wzsock;return 0}
if {[string first Error $outtitle] !=-1} {puthelp "NOTICE $nick :Location not found, please check spelling.";close $wzsock;return 0}

change it to this:
if {![regexp {<title>(.*?)</title>} $html match outtitle]} {
  puthelp "NOTICE $nick :You need to supply more information for that location.."
  close $wzsock;return 0
}
if {[string first Search $outtitle] !=-1} {puthelp "NOTICE $nick :Check your syntax, use .wz -help";close $wzsock;return 0}
if {[string first Error $outtitle] !=-1} {puthelp "NOTICE $nick :Location not found, please check spelling.";close $wzsock;return 0}

That will at least give a proper error message to the user, rather than cause a tcl error.

DragnLord · Post by **DragnLord** » Mon Sep 28, 2009 11:29 pm

Earlier versions of the script did return lists of locations, however that was removed due to user requests and complaints. I may include an option for that feature in a future version after 4.2.6, which has already been uploaded to the archives.

spithash · Post by **spithash** » Thu Sep 16, 2010 10:44 am

DragnLord,

If you add some flood protection, like, how many trigger requests per how many seconds.. would be AWESOME!

When a user floods a trigger, the bot will post the requests without stopping and even worse, when the script is set to:

Code: Select all

set wz_outmeth putserv

or even worse to:

Code: Select all

set wz_outmeth putquick

then the bot excess flood quits.

Even more annoying when you even have that set to "puthelp" and someone trigger floods in the channel and the bot HAS to post EVERYTHING

Takes time!!!

CtrlAltDel · Post by **CtrlAltDel** » Sat Jan 22, 2011 10:20 am

All of a sudden this morning I'm getting "No Report" for temperature no matter what location I try.
You just knew it had been too long since they screwed it up.

Still the best weather script available. Thanks

planetb · Post by **planetb** » Sat Jan 22, 2011 12:17 pm

CtrlAltDel wrote:All of a sudden this morning I'm getting "No Report" for temperature no matter what location I try.
You just knew it had been too long since they screwed it up.

Still the best weather script available. Thanks

I'm also seeing the same issue :

New York, New York -- 11:17 AM EST Updated: 11:16 AM EST on January 22, 2011
Conditions: Temp: No report
Humidity: 32% Dew Point: 3°F / -16°C
Pressure: 30.01in / 1016.1hPa (Steady) Wind: 3.0mph / 4.8km/h / 1.3m/s Variable

planetb · Post by **planetb** » Sun Jan 23, 2011 5:16 pm

Not sure if DragnLord is still around. So I learned a little about tcl and started looking into the issue a little. made a couple changes and now the script is working again. Looks like they changed the website format a little.

Changes I made :

Code: Select all

Line 782 : changed "&#176" to "&deg"

         if {[regexp {Temperature} $conditions]} {regexp {Temperature (.*?)°F / (.*?)°C} $conditions match temp mtemp} else {regexp {[[:blank:]](.{1,5}?)°F} $conditions match temp; regexp {F /[[:blank:]]*?(.*?)°C (.*?) [[:alpha:]]*?:} $conditions match mtemp cond}

Code: Select all

Line 792 and 793 : Changed "&#176" to "&deg" also.

         if {[regexp {Windchill} $conditions]} {regexp {Windchill: (.*?)°F / (.*?)°C [[:alpha:]]*:} $conditions match ichill mchill}
         if {[regexp {Heat Index} $conditions]} {regexp {Heat Index: (.*?)°F / (.*?)°C [[:alpha:]]*:} $conditions match ihindex mhindex}

Found this by putting "putlog $conditions" right above line 782 and then looking in the log file "eggdrop.log" after I had someone run a .wz . Dew point was also already set as &deg

Log file entry :

[16:14] Updated: 4:07 PM EST on January 23, 2011 26.1°F / -3.3°C Clear Windchill: 17°F / -8°C Humidity: 19% Dew Point: -13°F / -25°C Wind: 9.0mph / 14.5km/h / 4.0m/s from the NW Wind Gust: 13.0mph / 20.9km/h / 9.3m/s Pressure: 30.14in / 1020.5hPa (Rising) Visibility: 10.0miles / 16.1kilometers UV: 1 out of 16 Pollen: .10 out of 12Pollen Forecast new! Clouds: Clear - (Above Ground Level) Elevation: 52ft / 15m

New York, New York -- 4:07 PM EST Updated: 4:07 PM EST on January 23, 2011
Conditions: 26.1°F / -3.3°C | Clear
Humidity: 19% Windchill: 17°F / -8°C Dew Point: -13°F / -25°C
Pressure: 30.14in / 1020.5hPa (Rising) Wind: 9.0mph / 14.5km/h / 4.0m/s from the NW

Vasago · Post by **Vasago** » Sun Jan 23, 2011 6:19 pm

Thank you Planetb for the fix you came up with. My husband usally fixes things but he couldn't figure this one out.

CtrlAltDel · Post by **CtrlAltDel** » Sun Jan 23, 2011 11:14 pm

planetb: Many thanks

bluzman · Post by **bluzman** » Mon Jan 24, 2011 6:21 am

Thanks planetb, your fix worked perfectly.

Cheers!

webmastir · Post by **webmastir** » Fri Jan 28, 2011 12:30 am

can anyone upload a working tcl somewhere w/ planetb's fixes integrated?

thx

Post by **caesar** » Fri Jan 28, 2011 2:40 am

Can't you edit the tcl file in a text editor and replace all instances of "&#176" with "&deg"? Basically this is what he did.

webmastir · Post by **webmastir** » Fri Jan 28, 2011 8:38 am

caesar wrote:Can't you edit the tcl file in a text editor and replace all instances of "&#176" with "&deg"? Basically this is what he did.

lol. well ya, i suppose i could

. i swore when i looked at his post last night it was quite a bit more tweaking. seems easy enough. will try it out. thx

edit: worked...thx

egghelp/eggheads community

DragnLord's weather script

Specifying country code

No Report

Re: No Report

Re: No Report