Need some help.

ppslim · Post by **ppslim** » Thu Nov 22, 2001 9:52 am

You are making calls to "nick2hand" all the time when it is not needed, as the $handle variable has this contained for us. Note, that doing "nick2hand" calls may actualy give you problems witht he script. It may kick owners for spamming, or even protect non-owners. The "nick2hand" command has to search the userfile each time it is called, and may detect a different person to the one set in the $handle variable.

You keep using a long line to generate a banmask, when it actualy a very simple command that doesn't require you to do a "getchanhost"

Code: Select all

set banmask "*!*@[lindex [split $host @] 1]"

Just to check, you do not want to punish owners, masters, partyline user or friends?

You keep using the variable $botnick, mainly in the "isop" command. Using the "botisop" command instead, it saves you having to even bother with it's nickname.

Change the "putserv" command to output "mode" as caps, as the server may need it as a requirment.

Post by **caesar** » Thu Nov 22, 2001 10:33 am

I don't want to kick users and op's. I see I have many problems .. It's normal .. coz I'm at the begining.

.. and hope one day to have knolege as you have.

Help me with an good code .. of what I try to do .. or show me what lines r wrong. Thx!

Post by **caesar** » Fri Nov 23, 2001 6:51 am

I did as u told me to do but still nothing.
I replaced my banmask with set banmask "*!*@[lindex [split $host @] 1]", $n2hand with $handle and now I have a problem with "botisop". How is this command coz I din't do it right and this is not working. Any sugestions .. or some help ?

Thx!

[ This Message was edited by: caesar on 2001-11-23 03:52 ]

ppslim · Post by **ppslim** » Fri Nov 23, 2001 11:51 am

If you read through tcl-commands,doc, you will see the usage for all the commands in eggdrop.

Post by **caesar** » Fri Nov 23, 2001 12:25 pm

Ok ppslim .. I'll look .. but I don't think that I'll fine much there .. but I'm optimist.

I'll put an reply in here if something new comes up.

Thx again.

Wcc · Post by **Wcc** » Fri Nov 23, 2001 7:26 pm

The syntax for botisop, as found in doc/tcl-commands.doc, is "botisop <channel>"

Post by **caesar** » Fri Nov 23, 2001 9:51 pm

Iahh .. I found it

.. "if [botisop $channel]" .. Thx!

--- Code ---
bind pubm - "*#*" pub_dont_advertise

proc pub_dont_advertise {nick host handle channel arg} {
global botnick
set banmask "*!*@[lindex [split $host @] 1]"
set bantime "1440"
if [botisop $channel] {
if {[string match "*#mychan*" $channel]} { return }
if {([matchattr $handle m] || [matchattr $handle p] || [matchattr $handle b] || [matchattr $handle n] || [matchattr $handle o])} { return }
newchanban $channel $banmask $bantime "Don't advertise!"
putserv "KICK $channel $nick

on't advertise!"
putserv "MODE $channel +b $banmask"
return 1
}
}

putlog "Don't advertise .. loaded."
--- Code ---

Yeee .. I did it

Check this out and see if there r bugs or something. Works fine for me! .. and is just I did needed.

Thx again ppslim !!!

Post by **caesar** » Fri Nov 23, 2001 10:04 pm

Hehehe .. for an web page I used "if {[string match "*www.my.page.here*" $arg]} { return }" and work's fine. Yupii .. for this one I answerd myself.

Post by **caesar** » Fri Nov 23, 2001 10:38 pm

Hi again. I'm bodering u with an other tcl of my own.

- Cut -
proc anti_notice {nick host handle channel arg} {
global botnick
set channel "$arg"
set banmask "*!*@[lindex [split $host @] 1]"
set bantime "1440"
if [botisop $channel] {
if {([matchattr $handle m] || [matchattr $handle p] || [matchattr $handle b] || [matchattr $handle n] || [matchattr $handle f])} { return }
if {$arg == "$channel"} {
- Cut -

As u see this is a part of an anti notice tcl. As it is right now, I meen the entire code works fine, but .. I want to change this 2 lines.

- Cut -
set channel "$arg"
- Cut -

and

- Cut -
if {$arg == "$channel"} {
- Cut -

Any sugestions in what to change them ?
Thx!

ppslim · Post by **ppslim** » Fri Nov 23, 2001 11:03 pm

I fail to see what you are trying to do.

Post by **caesar** » Sat Nov 24, 2001 7:27 am

- Original Code -
bind notc - * anti_notice

proc anti_notice {nick host handle channel arg} {
global botnick
set channel "$arg"
set banmask "*!*@[lindex [split $host @] 1]"
set bantime "1440"
if [botisop $channel] {
if {([matchattr $handle m] || [matchattr $handle p] || [matchattr $handle b] || [matchattr $handle n] || [matchattr $handle f])} { return }
if {$arg == "$channel"} {
newchanban $channel $banmask $bantime "Don't do channel notices."
putserv "KICK $channel $nick

on't do channel notices."
putserv "MODE $channel +b $banmask"
return 1 }
}
}
- Original Code -

I just want to change 2 lines if it's possible, in a way or other. Any sugestions ?

- Line 1 -
set channel "$arg"
- Line 1 -

and

- Line 2 -
if {$arg == "$channel"} {
- Line 2 -

Thx!

PS: This is and want's to be an Anti Channel Notices.

Petersen · Post by **Petersen** » Sat Nov 24, 2001 9:27 am

you've not read the proc arguments properly from tcl-commands.doc

try this

Code: Select all

bind notc - * anti_notice 

proc anti_notice {nick host handle text {dest ""}} { 
global botnick
if {$dest==""} { set dest $botnick }
if {[validchan $dest]} { 
set banmask "*!*@[lindex [split $host @] 1]" 
set bantime "1440" 
if {[botisop $dest]} { 
if {([matchattr $handle m] || [matchattr $handle p] || [matchattr $handle b] || [matchattr $handle n] || [matchattr $handle f])} { return 0 } 
newchanban $dest $banmask $bantime "Don't do channel notices." 
putserv "KICK $dest $nick don't do channel notices." 
putserv "MODE $dest +b $banmask" 
return 1 
} 
} 
}

note that you might wanna protect channel |+n and |+f as well from this

[ This Message was edited by: Petersen on 2001-11-24 06:28 ]

[ This Message was edited by: Petersen on 2001-11-24 06:28 ]

Post by **caesar** » Sat Nov 24, 2001 8:09 pm

Thx! .. btw .. u forgot an ":"

- Cut -
"putserv "KICK $dest $nick don't do channel notices."
- Cut -

shoud be

- Cut -
"putserv "KICK $dest $nick

on't do channel notices."
- Cut -

Work's great. Thx!

Petersen · Post by **Petersen** » Sat Nov 24, 2001 8:46 pm

yah i know, cos i copy/pasted that bit and missed the : cos of the smilies.

Post by **caesar** » Thu Nov 29, 2001 9:28 am

I see. Well I'm back with a new question about a previous tcl of my own.

- Code -

bind pubm - "*#*" pub_dont_advertise

proc pub_dont_advertise {nick host handle channel arg} {
global botnick
set banmask "*!*@[lindex [split $host @] 1]"
set bantime "1440"
if [botisop $channel] {
if {([matchattr $handle m] || [matchattr $handle p] || [matchattr $handle b] || [matchattr $handle n] || [matchattr $handle o])} { return }
if {[string match "*#mychan*" $channel]} {return }
newchanban $channel $banmask $bantime "Lame advertise!"
putserv "KICK $channel $nick :Lame advertise!"
putserv "MODE $channel +b $banmask"
return 1
}
}

putlog "Don't advertise .. loaded."
- Code -

With this code he react's at all words. Any sugestions to fix this problem ?