i need basic script: !kill, !kline

[Sir_Fz]

the string length is to check if the string is empty, so [split $arg] would still be recommended... or not ?

[strikelight]

I think checking $arg as the first thing inside the proc would make the most sense. Then you would avoid all that work for nothing. No need to split an empty string just to find out it's empty
The best way to check if a variable is empty (imo) is

Code: Select all

if {[string length $arg]} {not empty} {empty}

That's nice and all... but as in this case, we are interested in checking for TWO (2) arguments within arg... thus, if only one is set instead of two, your check would give it a pass, when it should have failed...

For this situation caesars (+users fix) would be the best answer:

Code: Select all

if {[llength [split $arg]] == 2} { ... }

[strikelight]

the string length is to check if the string is empty, so [split $arg] would still be recommended... or not ?

'string length' is a STRING operation (hence the 'string' word)
'llength' is a LIST operation (hence the 'l' letter in front)

Given: $arg is a string

for 'llength' we need a list parameter... thus we split the string ($arg) converting it into a list.

for 'string length', $arg is already a string thus we do not need to convert it.

[Sir_Fz]

so if {[llength [split $arg]] == 2} { ... } will check if the second word is empty then it will do whatever.... ?

[caesar]

The llength check will "test" if you have specified the two arguments that are needed, that's all, so yes, basicaly it would do the trick

[strikelight]

so if {[llength [split $arg]] == 2} { ... } will check if the second word is empty then it will do whatever.... ?

Not quite...
It will check if the length of the list is 2, implying that there are (no more than, and no less than) two non-empty elements within the [split $arg] list.

[Sir_Fz]

yes but i guess the reason would be more than one element
so the user would be [lindex [split $arg] 0] and the reason would be [lrange [split $arg] 1 end] so the llength wouldn't do it in this case ?

[strikelight]

yes but i guess the reason would be more than one element
so the user would be [lindex [split $arg] 0] and the reason would be [lrange [split $arg] 1 end] so the llength wouldn't do it in this case ?

To be honest, I wasn't really paying attention to the application, just the premise...

But yes, llength will still apply... just needs to be modded slightly...

Code: Select all

if {[llength [split $arg]] >= 2} { acceptable parameters code goes here }

(Greater than or equal to 2 param's).

[caesar]

It dosen't matter what arguments you use in order to function propertly. The [lindex [split $arg] 0] and the [lrange [split $arg] 1 end] are correct. Also, it can be equal or bigger than 2 or just equal or smaller or whatever you want, it will still work.

[Sir_Fz]

ok, I got how it works now, thanx

[strikelight]

Actually, upon furthur inspection of this case, with the given data,
the llength [split $arg]] == 2 is the correct assertion, and I will explain why...

The code mentioned in this thread was:

Code: Select all

putserv "KILL $user $reason"

Now, this will result in only using word 1 from $reason to issue the kill... to have a multi-word reason, this would need to be modified to:

Code: Select all

putserv "KILL $user :$reason"

[Sir_Fz]

lol, yes you're right.. the mistake of skipping the ":" is very common
also if you see in the first code given "reason is set to [lindex $arg 1]" so its only 1 word too

[caesar]

The

Code: Select all

set user [lindex [split $arg] 0]
set reason [lrange [split $arg] 1 end]

will do fine

[strikelight]

The

Code: Select all

set user [lindex [split $arg] 0]
set reason [lrange [split $arg] 1 end]

will do fine

Not without the mods mentioned in the last few posts...
quit trying to increase your post count, and read the posts :p

[caesar]

Huh? What changes can be applied to this two then? And I'm not "spaming" around for posts