Proc Finish?

[jnc_xavier]

when i execute this file i get the error as said below. plz help

Code: Select all

#Create a ns simulator
set ns [new Simulator]

#Open the NS trace file
set tracefile [open out1.tr w]
$ns trace-all $tracefile

#Open the NAM trace file
set namfile [open out1.nam w]
$ns namtrace-all $namfile

#===================================
#        Nodes Definition        
#===================================
#Create 3 nodes
set n0 [$ns node]
set n1 [$ns node]
set n2 [$ns node]

#===================================
#        Links Definition        
#===================================
#Createlinks between nodes
$ns duplex-link $n0 $n1 100.0Mb 10ms DropTail
$ns queue-limit $n0 $n1 50
$ns duplex-link $n0 $n2 100.0Mb 10ms DropTail
$ns queue-limit $n0 $n2 50

#Give node position (for NAM)
$ns duplex-link-op $n0 $n1 orient right-down
$ns duplex-link-op $n0 $n2 orient right-down

#===================================
#        Agents Definition        
#===================================

#===================================
#        Applications Definition        
#===================================

#===================================
#        Termination        
#===================================
#Define a 'finish' procedure
proc finish {}
{
    global ns tracefile namfile
    $ns flush-trace
    close $tracefile
    close $namfile
    exec nam -a out1.nam &
    exit 0
}

$ns at 10.0 "finish"

$ns run

ERROR THAT SHOWS UP:

wrong #args: should be "proc name args body"
while executing
"proc finish {}"
(file wired2node.tcl line 71)

[nml375]

In tcl, all arguments must be on the same line (though each argument may contain newlines)
Thus, this is incorrect:

Code: Select all

proc finish {}
{
...

The proper code would look like this:

Code: Select all

proc finish {} {
...

[jnc_xavier]

but that too aint working. could u plz help

[nml375]

Changing the definition of "finish" into this:

Code: Select all

proc finish {} {
  global ns tracefile namfile
  $ns flush-trace
  close $tracefile
  close $namfile
  exec nam -a out1.nam &
  exit 0
}

Should sort the posted error message. Please post any new error messages you get.

[sh.minaee]

I've did that, but this time i have this error :
ns: finish: wrong # args: should be "close channelId"
while executing
"close $tracefile # close tracefile"
(procedure "finish" line 5)
invoked from within
"finish"

[nml375]

Remove the comment (# close tracefile) from your code...
Or prefix the # with a ;
Such as this:

Code: Select all

...
close $tracefile ;# close tracefile