imdb-1.1.0.tcl help please

[sAnexeh]

Hi,

You can try to add the following line on #532:

Code: Select all

set genre [string map {"\n" "" } $genre]

So, that will change:

Code: Select all

set genre [string map {"|" "||" } $genre]
set genre [string trim $genre]

to:

Code: Select all

set genre [string map {"|" "||" } $genre]
set genre [string map {"\n" "" } $genre]
set genre [string trim $genre]

[name]

Thanks bro, it worked like a charm

[sAnexeh]

Yes, it really does help me, thank you.

Thanks bro, it worked like a charm

you're welcome!

[hazzlah]

Hey @all ,

have anybody a fix for %screens ?

THX

[sAnexeh]

Hey @all ,

have anybody a fix for %screens ?

THX

No, because IMDb removed "screens" from its output. Technically it can be done by doing a second lookup to the box office part (/business), but that would mean doubling the amounth of lookups to IMDb and would mean a significant increase in the time you have to wait for output.

If anyone knows a way to include screens (/business) in the output by adjusting the URL/querystring of IMDb it would probably be very easy to fix. Or, you know, get IMDb to put it back .

[creasy]

Besides %screens, the script doesn't seem to be returning a bunch of other data either:

Code: Select all

<bot> The Hunger Games (2012) - http://imdb.com/title/tt1392170/ - Directed by: Gary Ross - Genre: Adventure | Drama | Sci-Fi | Thriller - Release Date: N/A - Budget:        $78,000,000              <span class="attribute">(estimated)</span>       - Screens: N/A - Rating: N/A/10  ( N/A votes )
<bot> Plot: In a dystopian future, the totalitarian nation of Panem is divided into 12 districts and the Capitol. Each year two young representatives from each district are selected by lottery to participate in The Hunger Games. Part entertainment, part brutal retribution for a past rebellion, the televised games are broadcast throughout Panem. The 24 participants are - Runtime: 142min.

Anyone has a fix for those N/As and the extra info showing up in %budget?

[sAnexeh]

Anyone has a fix .. the extra info showing up in %budget?

change:

Code: Select all

set budget [string map {ˆ ˆ ? ?} $budget]

to:

Code: Select all

set budget [string range $budget 0 [expr [string first "<span" $budget] -1]]
set budget [string trim $budget]

(or simply add the lines right after set budget)

I will look into those N/A things later

[creasy]

Thanks sAnexeh.

[sAnexeh]

To fix ratings change:

Code: Select all

if [regexp {<strong><span itemprop="ratingValue">(.*?)</span></strong>} $html rating] {

to:

Code: Select all

if [regexp {<span itemprop="ratingValue">(.*?)</span></strong>} $html rating] {

To fix votes change:

Code: Select all

if [regexp {<span itemprop="ratingCount">(.*?)</span>} $html votes] {

to:

Code: Select all

if [regexp {<span class="small" itemprop="ratingCount">(.*?)</span>} $html votes] {

[sAnexeh]

Screens still can't easily be fixed afaik. The release date does seem to work in my scenario ([16:30] IMDB_DEBUG release date == 21 March 2012 (Netherlands)), so that might be a location issue.

[creasy]

Screens still can't easily be fixed afaik. The release date does seem to work in my scenario ([16:30] IMDB_DEBUG release date == 21 March 2012 (Netherlands)), so that might be a location issue.

Thanks again for the fixes sAnexeh. Could you please post your code for release date? I'll compare it with mine.

[sAnexeh]

Thanks again for the fixes sAnexeh. Could you please post your code for release date? I'll compare it with mine.

Sure, this is the one I use:

Code: Select all

if {[regexp {<h4 class="inline">Release Date:</h4>(.*?)<} $html dummy reldate]} {
set reldate [string trim $reldate]
set reldate [htmlcodes $reldate]
}

[creasy]

Sure, this is the one I use:

Code: Select all

if {[regexp {<h4 class="inline">Release Date:</h4>(.*?)<} $html dummy reldate]} {
set reldate [string trim $reldate]
set reldate [htmlcodes $reldate]
}

Thank you, that fixed it! For some reason I still had this code:

Code: Select all

    if {[regexp {<time itemprop="datePublished" .*?>(.*?)</time>} $html dummy reldate]} {
        regsub -all {[\n\s]+} $runtime {} runtime
    }

[sAnexeh]

Thank you, that fixed it! For some reason I still had this code..

That's old code! . Maybe spithash can add some fixes in the imdb.tcl he is hosting, otherwise I'll update it and put it somewhere.

[creasy]

That would be awesome!