mass-join-protection by SpiKe^^- Netsplits Problems.

[caesar]

Your issue was resolved?

[F|irT]

No Issue Resloved. still waiting for reply with good hands.

Caesar ,

Here u go With ur nick Spell Caerar .

[caesar]

Are you sure you don't have that netsplit_detected variable used in some script? Tried unloading everything and leaving only this script to see if it's working or not?

Let's try with adding some debugging tools by replacing:

Code: Select all

proc netsplit:unlock args {
   global netsplit_detected
   set netsplit_detected 0
}

with:

Code: Select all

proc netsplit:unlock args {
	global netsplit_detected
	putlog "netsplit_detected was set to: $netsplit_detected"
	set netsplit_detected 0
	putlog "netsplit_detected is now set to: $netsplit_detected"
}

In theory you should see:

Code: Select all

netsplit_detected was set to: 0
netsplit_detected is now set to: 1

[simo]

tried the debug on my own testnet reproducing a netsplit with a bunch of local bots to join after and in all cases it still triggered the anti mass join and booted them even tho i reproduced a netsplit

Quits :   Amigo   ~uid1234@Amigo.Premium.net (paradigm.hub.dal.net diamond.hub.dal.net)

i also checked PL and it didnt display the:

netsplit_detected was set to: 0
netsplit_detected is now set to: 1

[willyw]

i also checked PL and it didnt display the:

netsplit_detected was set to: 0
netsplit_detected is now set to: 1

While you wait for caesar :

Do: .console and check your console flags to be sure you have plenty, so you can really see what is going on.

Then do: .tcl putlog "this is a test"
to be sure that you can see it.

[caesar]

I'm an idiot. Try with this code:

Code: Select all

set netsplit_detected 0

bind raw - QUIT netsplit:detect

proc netsplit:detect {from key arg} {
   global netsplit_detected
   if {[info exists netsplit_detected]} return
   set arg [string trimleft [stripcodes bcruag $arg] :]
   if {[string equal "Quit:" [string range $arg 0 4]]} return
   if {![regexp -- {^([[:alnum:][:punct:]]+)[[:space:]]([[:alnum:][:punct:]]+)$} $arg _arg s1 s2]} return
   if {[string match "*.dal.net" $s1] && [string match "*.dal.net" $s2]} {
      set netsplit_detected 1
	  putlog "netsplit_detected was set to: $netsplit_detected"
      utimer 180 [list netsplit:unlock]
   }
}

proc netsplit:unlock args {
   global netsplit_detected
   set netsplit_detected 0
   putlog "netsplit_detected was set to: $netsplit_detected"
}

and "trigger" an net-split then wait and see if after 3 minutes is set back to 0.

Make sure you do a .restart as .rehash isn't very reliable apparently.

Edit: Fixed variable.

[simo]

tried that and it gave me same result even after netsplit it kept detecting mass joins

also willyw for logs i have this in place

mjkcobxs (msgs, joins, kicks/modes, cmds, misc, bots, files, server).

[willyw]

...

also willyw for logs i have this in place

mjkcobxs (msgs, joins, kicks/modes, cmds, misc, bots, files, server).

Then do: .tcl putlog "this is a test"
to be sure that you can see it.

[simo]

Then do: .tcl putlog "this is a test"
to be sure that you can see it.

oh forgot to mention i did that as well and worked i saw it in PL

[simo]

i tested few times on testnet reproduced netsplit but after rejoins users still got kickbanned

[caesar]

You don't see anything because of this line:

Code: Select all

if {[info exists netsplit_detected]} return

because set netsplit_detected 0 is declared above.

Just noticed this as was trying to figure out why this is failing. /facepalm

I need a break from work lol

[F|irT]

Can any one give me fresh file after if it's slove the netsplit issue . i don't understand what to copy and where to paste thanks.

[caesar]

Find that line in your code and remove it. It's THAT simple.

[simo]

after taking out


if {[info exists netsplit_detected]} return


i initiated a netsplit on my testnet again and the results are still the same meaning even after a netsplit it detects rejoined users from netsplit as join flood and boots them out

also gettin error:

Tcl error [netsplit:detect]: can't read "text": no such variable

[simo]

i changed the $text to $arg and that seemed to made it work

also since it kept setting channel lock modes i added the check for netsplit in join proces as well wich stopped that

nice work caesar tnx again