Traceroute...

[elajt]

I just can’t get this right, should it be with or without $text?
There is one error that says that the arguments are wrong, what does this mean? And how should I change it? This is strange I think, because usually, when redesiged this script to use another command, like reading from a document, it works..

Here's the script:

Code: Select all

bind pub o ?access pub:traceroute

proc pub:traceroute {nick uhost hand chan text} {
set input [open "|/bin/traceroute $text" r]      

while {![eof $input]} {
catch {set contents [gets $input]}
putserv "NOTICE $nick :$contents"
}
close $input
}

And here is the error i get :

Code: Select all

Tcl error [pub:trace]: wrong # args: should be "catch command ?varName?"

...

[tainted]

I can't see anything wrong with that code offhand, perhaps try a .restart to clear out any previous 'test' versions of the script? That catch command is in perfect working order, though it may be something with the data fed into it from $input. A pair of "s might help around the gets command although.

[ppslim]

As well as this, you could use the "exec" command instead.

While exec is gurenteed to block, unlike open, the way this traceroute script is setup, it would block anyway, so there is no real disadvantage to using this.

Instead if using gets or read to read the ouput from the open file pointer, the data is simply returned to the variable straight away.

You simply split the output using \n, and output each line.

[elajt]

Ok, thanx!