what`s wrong in this script ?

[Pitchat]

hi
this is suppose to be a script that warn if the bot is been deop by somebody but it doesnt work at all

bind mode - * modedeop

proc modedeop {nick host hand chan mode who} {
global botnick botname

if { $mode == "-o" && $who == $botnick && [strlwr $botnick] != [strlwr $nick] } { putbot "Precieuse" "msgbot $nick ($host) m'a déopé sur $chan" ; return 0 }

set banhost "*!*[string range $who [string first @ $who] e]"
set bothost "*!*[string range $botname [string first @ $botname] e]"

if { $mode == "+b" && $banhost == $bothost} { putbot "Precieuse" "msgbot $nick ($host) m'a banni sur $chan" }
return 0 ;
}

bind kick - * kickmsg
proc kickmsg {nick host hand chan knick reason } {
global botnick
if {[strlwr $knick] == [strlwr $botnick] } { putbot "Precieuse" "msgbot $nick ($host) m'a kické sur $chan (raison invoquée : $reason)"}
}

putlog "deop check script lancé - Date: 4-02-01"


thanks
Pitchat[/code]

[De Kus]

there are really a few misstakes.
fot comparing the banhostmark i would try using string match comparing "$botnick![getchanhost $botnick]" with "$who". i hope string match can compare with wildcards, i think it can, but im not sure. but i am sure there is a way to do that.
then i dunno if you can use ; to end command lines, ussually you start a new line . but if you use elseif instead of if in the second time, you dont need the first return 0 at all.
if you pray, perhaps it works:

Code: Select all

bind mode - * modedeop

proc modedeop {nick host hand chan mode who} {
  global botnick botname
  if { $mode == "-o" && $who == $botnick && [strlwr $botnick] != [strlwr $nick] } {
    putbot "Precieuse" "msgbot $nick ($host) m'a déopé sur $chan" 
  } elseif { $mode == "+b" && [string match [string tolower "$botnick![getchanhost $botnick]"] [string tolower $who]] } {
    putbot "Precieuse" "msgbot $nick ($host) m'a banni sur $chan"
  }
}

bind kick - "* $botnick" kickmsg

proc kickmsg {nick host hand chan knick reason } {
  putbot "Precieuse" "msgbot $nick ($host) m'a kické sur $chan (raison invoquée : $reason)"
}

eh btw, does strlwr the same the string tolower?! if not and strlwr is called a not availbe function, replace it ..

[caesar]

'strlwr' is a proc from alltools.tcl and stands for 'string tolower', so it's correct

[caesar]

And a simple sugestion, replace:

Code: Select all

  } elseif { $mode == "+b" && [string match "$botnick![getchanhost $botnick]" $who] } {

with:

Code: Select all

  } elseif { $mode == "+b" && [string match "$who" "$botname"]} { 

[De Kus]

bad suggestion, i think. because $who will not be a nick, but a hostmark in case of a +b chanmode .
but you are right, i should tolower the string!

lets show it in an example. lets say we are on an irc server having a bot called "StarZ|Clan" on hostmark "ben1@server4.phoenix-shells.de". someone sets the ban "*!*@server4.phoenix-shells.de". i am sure "*!*@server4.phoenix-shells.de" != "StarZ|Clan". but a ban "s*|clan!*@*.*" woudnt match "StarZ|Clan!ben1@server4.phoenix-shells.de", either, but would be a legal ban against the bot. its time we really need tolower again .
so [string match "$botnick![getchanhost $botnick]" $who] must be replaced with

Code: Select all

[string match [string tolower "$botnick![getchanhost $botnick]"] [string tolower $who]]

[Pitchat]

thanks alll it works fine

[De Kus]

means the [string match m*h muh] expression works? great, ill remember that .

[stdragon]

It might be easier to say

string match -nocase "$botnick![getchanhost $botnick]" $who

[caesar]

Humm.. yes, that will be usefull only for the +b bind.

[ppslim]

It might be easier to say

string match -nocase "$botnick![getchanhost $botnick]" $who

And I thought better of you

Why use a matching function, when theres no wildcards. "string equal" is more suited gfor this.

[stdragon]

Actually since this is from a +b, $who may have wildcards.

But I should have read more carefully instead of copy and pasting, because the arguments are in the wrong order.

string match -nocase $who "$botnick![getchanhost $botnick]"

(the pattern comes before the string to match against)

[De Kus]

Why use a matching function, when theres no wildcards. "string equal" is more suited gfor this.

if i want to make a equal check i would simply use $who == "$botnick![getchanhost $botnick]" .

but thx stdragon for correcting the expression for string match, i knew only seen it somewhere like this ^.^.

[stdragon]

Not to nitpick but using == still makes it case sensitive.

% expr {"asdf" == "asdf"}
1
% expr {"asdf" == "ASDF"}
0

The best way to check that is as ppslim said,
if {[string equal -nocase $string1 $string2]} {
blah
}