talk procedure

[stammer]

hi there!
I'm writing a talk script for my windrop but it can't work. Here is it

#set flags
setudef flag talk
set kflag 6
set say "sin"

#bind section
bind pub - * pub:talk

proc pub:talk {nick host hand chan text} {
global botnick nanypa kflag say

if {([lsearch -exact [channel info $chan] {+talk})&&([string match $say $text])] != -1} {
set strs [lindex $nanypa [rand [llength $nanypa]]]
while {($rndnick != $nick)&&($rndnick != $botnick)} {
set chanl [chanlist $chan]
set nc [llength $chanl]
set rdnick [rand $nc]
set rndnick [lindex $chanl [expr $rdnick+1]]
}
if {[string match "NiCk" $strs]} {
set sl [string length $strs]
set sle [expr $sl-3]
for {set a 1} {$a < $sle} {incr a} {
set b [expr $a+4]
if {[string range $strs $a $b] == "NiCk"} {
set strt [string range $strs 1 [expr $a-2]]
set end [string range $strs [expr $b+2] sl]
set strs [join [list $strt $rndnick $end] " "]
}
}
}
set out [join [list $nick $strs] " "]
utimer [rand 8] [putchan $chan $out]
}

return 1
}

i give you short explanation of what procedure does:

1. get random message from list 'nanypa'
2. get random nick from channel
3. if (random nick == botnick) && (nick =='nick of speaking person') gets new random nick
4. check if message contain word 'NiCk'
5. switch word 'NiCk' with random nick from '2'
6. say message on channel

ohhh sorry it's for TCL forum my mistake

[ppslim]

You genraly need to go over, and look at the formatting, and how the commands look/flow.

Here are a few points I noticed right off.

Code: Select all

if {([lsearch -exact [channel info $chan] {+talk})&&([string match $say $text])] != -1} {

It looks like you have simple added the "string match" command in here, which has totaly wrecked the formatting of this command.

Go over it slowly, and split it down into its most basic parts. If need be, seperate it into seperate "if" command, then re-construct it.

Code: Select all

while {($rndnick != $nick)&&($rndnick != $botnick)} {

This will cause an error once the code reaches it, because $rndnick doesn't exist.

A simple initialisation of this should stop the error, but not totaly fix it.

You have created a while loop, that loops until $rndnick is set, to the bots own nickname, or the person that caused the command to trigger.

Unless we know what you try to do at this point, we can't realy help.

You genraly, need to go over it, and loop at what each part does. If need be, place imaginary data on paper, and see how the code would flow, if you used it.

[stammer]

thanks

can you tell me how to loop until random nick is not $botnick or $nick?
is there a way to do this in TCL

[ppslim]

Well - You need a little bit more code that that for your while loop then.

First of all, I understand what you are trying to do with the loop now. This is a quick and simple method, but it presents flaws.

If there is only the person that made the request, and the bot in the channel (2 nicknames), then it will loop forever, as it will never find anybody else.

There are ways around this, measure howmany people are in channel, if there are only 2, ignore the request.

So you would do somthing like

Code: Select all

set chanlist [chanlist $chan]
if {[llength $chanlist] <= 2} { return }
set rndnick ""
while {($rndnick == $botnick) || ($rndnick == $nick)} {
  set idx [rand [llength $chanlist]]
  set rndnick [lindex $chanlist $idx]
  set chanlist [lreplace $chanlist $idx $idx]
}

The above code, first make a variable with a list of users, so we don't continualy call the chanlist command.

Then we check if it has two values or less, and quit the script if not, so we don't get stuck in a loop. Where it says return, you can display a error message to the user if you like.

Next we start the loop, and keep looping which any of the value match.

In the loop, we first collect a random value, from and including 0, up to the the length of the channel list, minus 1.

We then set $rndnick to the nickname of the person this index relates to.

On top, we finaly remove the persons name we collected, from the list of users. This gurentees that if we have to go through the loop, there i no way of obtaining the same value twice.

Once the while loop no longer matches (gurenteed no longer than three loops), we can continue on.

[stammer]

thaks alot ppslim i modified a bit and now it works like i want .

[stammer]

Here is it

Code: Select all

proc pub:talk {nick host hand chan text} {
	global botnick nanypa say

	if {[lsearch -exact [channel info $chan] {+talk}] != -1} {
		if {[string match -nocase "*$say*" $text]} {
			set chanlist [chanlist $chan] 
			if {[llength $chanlist] > 2} {
				set rndnick $botnick
				set strs [lindex $nanypa [rand [llength $nanypa]]] 
				while {($rndnick == $botnick) || ($rndnick == $nick)} { 
					set idx [rand [llength $chanlist]] 
					set rndnick [lindex $chanlist $idx] 
					set chanlist [lreplace $chanlist $idx $idx] 
				}
				set lst [lreplace {"NiCk" "."} 1 1 $rndnick]
				set strs [string map $lst $strs]
			} else {
				set strs "NiCk"			
				while {[string match "*NiCk*" $strs]} {
					set strs [lindex $nanypa [rand [llength $nanypa]]]
				}
			}
			
			set out [join [list $nick $strs] " "]
			utimer [rand 8] [putchan $chan $out]
		}
	}
	
	return 1
}