Join Flood Protection (need help)

Gothic-Angel · Post by **Gothic-Angel** » Sat Apr 05, 2003 7:09 pm

I'm trying to figure out how I could start writting join flood protection, I want it to be pretty simple if 8 users join i want the bot to set mode "MR" then remove in a set time prolly 15-30 secs. If there is already one around that I couldn't find I'd be greatful if someone would point me towards it so I could look off it to see how its setup.

If not, I could use some help starting this tcl.

tainted · Post by **tainted** » Sun Apr 06, 2003 2:05 am

I am pretty sure either netbots or another script here supports this, almost. The only thing you may need to edit is the actual mode that is set, most set +i and sometimes +m that I have seen.

Post by **caesar** » Sun Apr 06, 2003 4:46 am

I've did one exactly like you've asked a time ago and can be found here.

Gothic-Angel · Post by **Gothic-Angel** » Mon Apr 07, 2003 7:41 pm

I see, one problem with that is he mode floods. Set's MR like 7 times. I tried changing the proc around to.

Code: Select all

if {$nick == $botnick || ![botisop $chan]} { return 0 }
if {![getchanmode $chan == +cMnRtl]} { return 0 }
set nojoins [lindex [split $jtu ":"] 0]
set insec [lindex [split $jtu ":"] 1]
set unlockin [lindex [split $jtu ":"] 2]
incr val($chan)
utimer $nojoins [list reset $chan]
if {$val($chan) >= $nojoins} {
putquick "MODE $chan +MR"
utimer $unlockin [list unlock $chan] }
}

I get an error though [7:41pm] (CustomerServ|ce): [19:41] Tcl error [njf:join]: wrong # args: should be "getchanmode channel"

I had it working last night, but I was drunk and can't figure out what I did so that doesn't help. I know it was working last night close to that or something.

Post by **caesar** » Tue Apr 08, 2003 2:33 am

Well, it should be: if {[getchanmode $chan] == "+scRtMn"} { return }

And how dose he the mode floods? Be more specific please.

Gothic-Angel · Post by **Gothic-Angel** » Tue Apr 08, 2003 6:36 pm

If 15 bots on a botnet join, he set's mode +MR about 6 times.
so its

Blah has set mode +MR
Blah has set mode +MR
Blah has set mode +MR
etc...

Post by **caesar** » Wed Apr 09, 2003 1:26 am

He waits with the first +MR thing 60 seconds then removes them then put them back? Is this what are you talking about? I'm running it on two bots and haven't seen something like that. It's reacting on a masive join like after an netsplit or something and is doing the +m thing only once. I'll test myself with an large botnet on my private irc server.

Post by **caesar** » Wed Apr 09, 2003 2:04 am

Did some tests and he puts the modes only once. Also noticed something weird about that *array fix*, isn't working well, remove the ! from the "if {![string match..." line or remove the array fix, seems to be the same thing afterall. Humm..

Also, on what network or what tipe of irc server have you done your tests? I've did mine on an Unreal3.2-beta15 and is working fine.

Gothic-Angel · Post by **Gothic-Angel** » Wed Apr 09, 2003 3:37 pm

All my test's were done ont he latest version of bahmaut, I figure this is pretty simple to solve. Just check the channel mode before he places the +MR ( i just made a small change from +m to +MR ) then he shoudn't mode flood.

Let's say bot is in channel #blah, then 15 people join.

bot has set mode +MR
bot has set mode +MR
bot has set mode +MR
Gothic-Angel says wtf
bot has set mode +MR
bot has set mode +MR

then 60 seconds later
bot has set mode -MR
bot has set mode -MR
bot has set mode -MR
bot has set mode -MR
bot has set mode -MR

Post by **caesar** » Wed Apr 09, 2003 4:18 pm

I've tested it on ircu and Unreal and haven't seen this mass modes, guess it's the server fault, it's called desync or something like this. Test it on another server, different than bahmaut. Btw, isn't this the irc server Dalnet uses?

Gothic-Angel · Post by **Gothic-Angel** » Wed Apr 09, 2003 9:06 pm

Yes, there are a few other networks that use it too.

Post by **caesar** » Thu Apr 10, 2003 3:25 am

An simple test should reveal who's fault is. Test this:

Code: Select all

bind pub o|o !bla pub:bla

proc pub:bla {nick host handle channel arg} {
if {![botisop $channe]} { return }
putserv "PRIVMSG $channel :placing mode 1"
pushmode $channel +m
putserv "PRIVMSG $channel :placing mode 2"
pushmode $channel +m
putserv "PRIVMSG $channel :placing mode 3"
pushmode $channel +m
}

If isn't server fault you should see something like:

placing mode 1
bot mode +m
placing mode 2
placing mode 3

else

placing mode 1
bot mode +m
placing mode 2
bot mode +m
placing mode 3
bot mode +m

Papillon · Post by **Papillon** » Thu Apr 10, 2003 4:14 am

instead of checking the chanmodes you could unbind the whole proc after the channel has been locked, then use a utimer which binds it again when the channel is "reopened"

ppslim · Post by **ppslim** » Thu Apr 10, 2003 5:04 am

Code: Select all

if {[getchanmode $chan] == "+cMnRtl"} { return 0 }

This is after the corrections.

Note, this is invalid checking, if you don't want it to flood the channel with +MR.

This is saying return if it is EXACTLY them modes, and not if it contains them modes. Not just that, but "getchanmode" must also return them in the order above, and not out of place like "+cRnMtl".

Maybe you should use somthing like

Code: Select all

set cm [getchanmode $chan]
if {(([string match {+*[MR]*[MR]*} $cm]) && ([llength [split $cm]] == 1)) || (([string match {+*[MR]*[MR]* *} $cm]) && ([length [split $cm]] > 1))} { return }

The above needs splitting down into component portions.

The first string match, checks to see if there is no key or limit set on the channel, and if not, check to see if the M & R modes are there. The second does the same mode matching, but only if a key or limit is there.

If +MR is set, it returns.

I am presuming this is what you want. Because you script isn't returning, it is setting +MR continualy.

Post by **caesar** » Thu Apr 10, 2003 5:14 am

I've added an putlog "bla" and seems to be correct. It was tryng to put the modes again and again. Thanks for the getchanmode tip and for the correction.