badjoin

Post by **caesar** » Mon Jun 02, 2003 3:31 am

proc my:bad:join {nick uhost handle channel} {
  if {![file exists $::badfile]} {
    putlog "Error: $::badfile dose not exist."
    return 0
  }
  if {![botisop $channel]} {
    return
  }
  if {$nick == $::botnick} {
    foreach luser [chanlist $channel] {
      if {$luser == $::botnick} {
        continue
      }
      set file [open "$::badfile" r]
      while {![eof $file]} {
        set line [gets $file]
        if {![string match "$uhost" "$line"]} {
          set mask "*!*@[lindex [split $uhost @] 1]"
          newchanban $channel $mask BadJoin "$::badreas" $::badtime
        }
      }
      catch {close $file}
    }
    return
  }
  set file [open "$::badfile" r]
  while {![eof $file]} {
    set lines [gets $file]
    foreach line $lines {
      if {$line == ""} {
        continue
      }
      set mask "*!*@[lindex [split $uhost @] 1]"
      putlog "$mask vs. $line"
      if {[string match "$mask" "$line"] || [string equal "$mask" "$line"]} {
        return
      }
      set mask "*!*@[lindex [split $uhost @] 1]"
      # newchanban $channel $mask BadJoin "$::badreas" $::badtime
      putserv "PRIVMSG $channel :banning $nick with $mask"
    }
  }
  catch {close $file}
}

When I have in list this masks *!*@somehting.com *!*@bla.com *!*@I.Have.Killed.The.Devil.So.God.Made.Me.An.Angel.org he "bans" me no matter if I have the *!*@I.Have.Killed.The.Devil.So.God.Made.Me.An.Angel.org hostmask. But if *!*@I.Have.Killed.The.Devil.So.God.Made.Me.An.Angel.org is the first mask in the list he dosen't ban me anymore. Any sugestions on what may be wrong in here?

Papillon · Post by **Papillon** » Mon Jun 02, 2003 5:13 am

well.. as a start..

1.gets only return one line at the time, so you don't need the foreach loop inside the while loop

2.You might want to add the -nocase options to the string match/equal checks(you only need the string match)

3.no need to set the mask twice in the while-loop

Post by **caesar** » Mon Jun 02, 2003 6:12 am

1. Thanks for the loop vs. foreach tip. Removed it.
2. Added the -nocase and no result. Same story..
3. Removed it. Added the first one just to see the $mask vs. $line result.

Now it's:

Code: Select all

if {[string match -nocase "$mask" "$line"]} {

I see it comparing: *!*@I.Have.Killed.The.Devil.So.God.Made.Me.An.Angel.org vs. *!*@I.Have.Killed.The.Devil.So.God.Made.Me.An.Angel.org and should return but it dosen't..

Papillon · Post by **Papillon** » Mon Jun 02, 2003 6:25 am

well, just a single space at the end of *!*@I.Have.Killed.The.Devil.So.God.Made.Me.An.Angel.org will make it return 0, just add another vildcard to the match, like this:

Code: Select all

if {[string match -nocase "$mask*" $line]} {

Post by **caesar** » Mon Jun 02, 2003 6:29 am

Nope. Same result..
on dcc:
(13:27:12) ::: <bot> [13:27] *!*@I.Have.Killed.The.Devil.So.God.Made.Me.An.Angel.org vs. *!*@I.Have.Killed.The.Devil.So.God.Made.Me.An.Angel.org

on channel:
(13:27:13) ::: <@bot> banning caesar with *!*@I.Have.Killed.The.Devil.So.God.Made.Me.An.Angel.org

Papillon · Post by **Papillon** » Mon Jun 02, 2003 6:50 am

Code: Select all

proc my:bad:join {nick uhost handle channel} { 
  if {![file exists $::badfile]} { 
    putlog "Error: $::badfile dose not exist." 
    return 0 
  } 
  if {![botisop $channel]} { 
    return 
  } 
  set mask "*!*@[lindex [split $uhost @] 1]" 
  if {$nick == $::botnick} { 
    foreach luser [chanlist $channel] { 
      if {$luser == $::botnick} { 
        continue 
      } 
      set file [open "$::badfile" r] 
      while {![eof $file]} { 
        set line [gets $file] 
        if {![string match "$uhost" "$line"]} { 
          newchanban $channel $mask BadJoin "$::badreas" $::badtime 
        } 
      } 
      catch {close $file} 
    } 
    return 
  } 
  set file [open "$::badfile" r] 
  while {![eof $file]} { 
    gets $file line
    if {$line == ""} { 
      continue 
    } 
    putlog "$mask vs. $line"
    if {[string match $mask* $line]} { 
      set found 1; break 
    }  
  } 
  if {![info exists found]} {
    # newchanban $channel $mask BadJoin "$::badreas" $::badtime 
    putserv "PRIVMSG $channel :banning $nick with $mask"
  }
  catch {close $file} 
}

I modified it a littlebit

it works now

Post by **caesar** » Mon Jun 02, 2003 7:02 am

Humm.. now it's working. I'll read up and see where I've screwed it up. Thanks.

Post by **caesar** » Mon Jun 02, 2003 7:09 am

Now I need to figure out a way I can match other hostmask with the $mask, some masks like *!*bla@* or *!*@*.something.com .. etc..