master commands and security

[arcane]

hi

i've got one question about security.
it's about the way i'm handling master commands:

Code: Select all

bind pub - !normalproc normalproc
bind pub - !!masterproc masterproc

proc masterproc {args} {
   if {[matchattr $nick $masterflags]} {
	set vmaster "1"
        call normalproc $args
        unset vmaster
   }
}

and in the normalproc:

Code: Select all

proc normalproc {args} {
  if {$somesetting || [info exists vmaster]} {
     do_something
  }
}

do you think this is insecure? i think it might well be. i just want to be sure because i don't really want to change all my code *g*.
do you think it would be enough to add host and chan (e.g. set vmaster($host,$chan) "1")?

[TALES]

i dont think the part of this is secure: set vmaster($host,$chan) "1")


take a look @ this : http://www.peterre.com/characters.html