foreach loops help

[Dw2k]

I have a silly problem, with both my code and my head
My head doesn't understand loops in loops, and neither does my bot, as the code is wrong, anyway I digress...

Code: Select all

proc cmd:opstatus {nick uhost hand chan args} {
	global botnick hubchan userchan
	
	set message ""
	
	foreach channel [channels] {
		if {[onchan $botnick $channel]} {
			if {![botisop $channel]} {
				foreach user [chanlist $channel] {
					if {![isop $user $channel]} {
						set message "$message \0034$channel\003"
						break
					} elseif {[isop $user $channel]} {
						set message "$message \00310$channel\003"
						break
					} 
				}
			}
		}
	}
	if {$message != ""} {
		log "opstatus\: $message"
	}
}

This is a small scanner that should look at each channel the bot is on and see if it is deop'ed, and if it is, is there any other user oped? It prints out the name of the channel in different colours if there are other ops or if there arent.

Problem being that is that it ignores this logic and prints out the \0034 line regardless if there are op's or not.

</long post>

Thanks for any help

[stdragon]

The logic is just a bit misplaced.

First loop: go through all the channels. This part is correct.

Second loop: go through each user in the current user.

If the user is not an op, print that message and break.
Otherwise, print the other message and break.

As you can see, the 2nd loop is only executed once, no matter what -- it just prints out one of the messages, depending on the first user it looks at.

You can probably figure it out now. Or ask again if you need more help.

[Dw2k]

Yeah thanks. Got it now with a bit a help and poke in the right direction.

My logic was never good