Problems with my small script

[Bomi]

Hi all,

I am very new in programming with Tcl and Eggdrop. I wanted to write a script, that writes the current number of users of a channel in a textfile.
Everytime a user joins the channel, the script opens the file "users.txt" and adds 1 to the existing number. And when a user leaves the channel, it substracts 1. But the script doesn't work, there's only a linefeed in the textfile. Where's my fault?

Here's my script:

Code: Select all

set channel "#channel"

bind join - * nc_join 
bind part - * nc_leave 
bind sign - * nc_leave 

if {![file exists users.txt]} {
 set none [open "users.txt" "w"]
 puts $none "0"
 close $none
}


proc nc_join { nick host hand chan } {
  if {$chan == $channel} {
	set in [open "users.txt" "r"]

	gets $in in_val
	close $in
	incr $in_val +1
	set out [open "users.txt" "w"]
	puts $out $in_val
	close $out
  }
}

proc nc_leave { nick host hand chan } {
  if {$chan == $channel} {
	set in2 [open "users.txt" "r"]
	gets $in2 in_val2
	close $in2
	incr $in_val2 -1
	set out2 [open "users.txt" "w"]
	puts $out2 $in_val2
	close $out2
  }
}

[awyeah]

Here try these scripts.
The main thing is to get the total channel users on the binds
of join, part, quit or when a netsplit occurs maybe.

Here are some scripts pre ready which do almost the same
thing, you can have an idea by maybe seeing their codes.

http://www.egghelp.org/tclhtml/3478-4-0 ... l-peak.htm

The first script I think will do the job for you in this result.
All scripts normally store channel peak users such as I have
a channel kick counter for my bot in .txt files myself.

[Bomi]

hmm, I think my problem is writing something into a file,

Code: Select all

puts $none "0"

because the script doesn't write the 0 into the file although this has nothing to do with the binds. Is there an other possibility to put a number into a file?

[Bomi]

I shrinked the script a little bit, but there's still the problem with the filecreation in line7, I always get a file with just a cryptic sign in it. If I replace line 15-17 with the comment-line, the script works fine but of course then it doesn't export the number into the file

Code: Select all

bind join -|- * nc_join
bind part -|- * nc_join
bind sign -|- * nc_join

if {![file exists users.txt]} {
 set none [open "users.txt" "w"]
 puts $none ""
 close $none
}


proc nc_join { nick host hand chan } {
	set visitors [llength [chanlist $chan]]
#	puthelp "PRIVMSG $chan : $visitors"
	set saveme [open "users.txt" "a"]
	puts $saveme $visitors
 	close $saveme
}

[Alchera]

This be of some help?

Code: Select all

# Create the storage file for users.
if {![file exists "users.txt"]} {
 set none [open "users.txt" w]
 close $none
 unset none
 if {![file exists "users.txt"]} {
  putlog "*** (notes) ERROR: Unable to write to \"users.txt\" ***"
  return 0
 }
}

[Bomi]

yeah, thx, the filecreation is working now. But there's still the problem with the cryptic sign that is exported into the file instead of the visitor-number.

Code: Select all

proc nc_join { nick host hand chan } {
	set visitors [llength [chanlist $chan]]
#	puthelp "PRIVMSG $chan : $visitors"
	set saveme [open "users.txt" w] 
	puts $saveme $visitors << Mistake must be here, I think.
 	close $saveme
}

The Logfile doesn't report any error, so where's my mistake?

[Bomi]

I solved the problem on my own:

I had to use this:

Code: Select all

puts -nonewline $saveme $visitors

instead of

Code: Select all

puts $saveme $visitors