regexp check

[Alchera]

I'm not that good with regexp but have this line of code and am wondering whether it could be done better. The aim being to exclude adding users to the bot with either [] or {} in their nick(s).

Code: Select all

if {[regexp -nocase -- {[\[\]\{\}\]]+} $text]} {sendcmd "privmsg $chan :Illegal characters in nick: \[\]\ \{\}\ ";return}

The above does work very well btw.

The "sendcmd" procedure is a custom one of mine.

[awyeah]

Well you can use string match as well Alchera if you don't want to add users in the bot which have [ ] { } in their nicks.

Code: Select all

if {([string match "*\[*\]*" $text]) || ([string match "*\{*\}*" $text])} { sendcmd "PRIVMSG $chan :Illegal characters in nick: \[\]\ \{\}\ "; return 0 }

Alternatively, you can also do a foreach loop and assign a list to the characters you want to exempt *\[*\]* *\{*\}* bla bla and then do a string match for each character if you don't want to use the || function.

I am not sure, but I think || (OR) will be faster than running the loop if I am correct. (faster in milli/nano seconds, heh)

regexp only matches for complex structures here the one you are using is not complex and quite simple. Furthermore regexp is quite slower than string match (has been proved on the forum), so I suggest you use string match here!

[awyeah]

By the way I forgot to mention:

Code: Select all

if {([string match "*\[*\]*" $text]) || ([string match "*\{*\}*" $text])} { sendcmd "PRIVMSG $chan :Illegal characters in nick: \[\]\ \{\}\ "; return 0 } 

Will match nicks like:
- aw[ye]ah
- Al[cher]a
- awe{so}me
- [p][r][n][c][e]
- a{s}s{k}i{c}k{e}r
- aw[[y]]eah etc...

If you only want to match nicks like:
- [awyeah]
- {Alchera}
- [elite] and etc...

You will need to use something like:

Code: Select all

if {(([string equal "\[" [string index $nick 0]) && ([string equal "\]" [string index [expr [string length $nick] - 1]]])) || (([string equal "\{" [string index $nick 0]) && ([string equal "\}" [string index [expr [string length $nick] - 1]]]))} { sendcmd "PRIVMSG $chan :Illegal characters in nick: \[\]\ \{\}\ "; return 0 }

Meaning you have to check the first and last characters of the nick by using string index. If the first and last character of the nick equals to [ and ] or { and } then you can go ahead and do your stuff.