Variable questions

daltonc · Post by **daltonc** » Sun May 01, 2005 3:48 pm

In my script I am setting a variable, the variable containts () and its giving me an error saying:

Cant set variable_name($chan): Variable is not an array.

Any idea on what to do about this?

KrzychuG · Post by **KrzychuG** » Sun May 01, 2005 5:19 pm

You already have "variable_name" set, and it's not an array. Maybe you're trying to use some predefined Eggdrop variables (like "config" for example) or overwrite variable from another script.

daltonc · Post by **daltonc** » Sun May 01, 2005 5:55 pm

Mmmmm... didnt work. This is my actual code:

Code: Select all

set get_chan_name [mysql_query "SELECT * FROM bot_channels"]
putlog "*** SETTING CHANNEL VARIABLES ***"

foreach row $get_chan_name {
        set chan_name "[lindex $row 1]"
       set chan_trigger "[lindex $row 3]"
       set chan_greeting "[lindex $row 4]"

       set chan_trigger($chan_name) "$chan_trigger"
       putlog "Set $chan_name trigger to $chan_trigger"

       set chan_greeting($chan_name) "$chan_greeting"

}

this is my error:

[17:54] can't set "chan_trigger(#testchannel)": variable isn't array
while executing
"set chan_trigger($chan_name) "$chan_trigger""
("foreach" body line 6)
invoked from within
"foreach row $get_chan_name {
set chan_name "[lindex $row 1]"
set chan_trigger "[lindex $row 3]"
set chan_greeting "[lindex $row ..."

Post by **Sir_Fz** » Sun May 01, 2005 6:29 pm

you can't set chan_trigger($chan_name) and chan_greeting($chan_name) since you already have set chan_trigger and chan_greeting, I suggest you erase the first sets, and set them directly to the arrays.

daltonc · Post by **daltonc** » Sun May 01, 2005 9:57 pm

Thanks man, didnt really relize I was doin that. But uhh anyways: is this correct?

if {[string tolower [lindex [split $arg] 0]] == "${chan_trigger($chan)}set" && [string tolower [lindex $arg 1]] == "greeting"} {

Its saying the $chan_trigger($chan) is not set when I know it set when I ran the script cause it says it set.

Anyideas?

De Kus · Post by **De Kus** » Mon May 02, 2005 3:54 am

forgot to make the var global? did you think of that the var might not be always initialized before first use?

daltonc · Post by **daltonc** » Mon May 02, 2005 9:40 am

Yup, I made it global, still doesnt work. ; /

[09:38] Tcl error [command:main:set]: can't read "chan_trigger": no such variable

De Kus · Post by **De Kus** » Mon May 02, 2005 12:21 pm

you should post more details about where that error happens, if you expect any help from us ^-^.

but should you be using something like that now?
set chan_trigger($chan_name) [lindex $row 3]

daltonc · Post by **daltonc** » Mon May 02, 2005 1:24 pm

No.. the on load event sets the variables like so $chan_trigger(#mychannel) so therefore in the command I should use $chan_trigger($chan) to get the channel. But its not working. I posted the exact error message that I got from telnet.

Post by **Sir_Fz** » Mon May 02, 2005 1:43 pm

There might be a conflict with cases. If #channel is lower case, then I suggest yo do: set chan_trigger([string tolower $chan_name]) [lindex $row 3]

daltonc · Post by **daltonc** » Mon May 02, 2005 2:34 pm

rofl, alright nothing seems to be working, I've tried everything. here is my whole code for the functions:

Code: Select all


bind pubm -|- *  command:main:set

### set chan vars
set get_chan_name [mysql_query "SELECT * FROM bot_channels"]
putlog "*** SETTING CHANNEL VARIABLES ***"

foreach row $get_chan_name {
       set current_chan_name "[lindex $row 1]"
       set current_chan_trigger "[lindex $row 3]"
       set current_chan_greeting "[lindex $row 4]"

       putlog "^B^_Starting $current_chan_name vars^_^B"

       global chan_trigger($current_chan_name)
       global chan_greeting($current_chan_name)

       set chan_trigger([string tolower $current_chan_name]) [lindex $row 3]
       putlog "Set $current_chan_name ^Btrigger^B to '$current_chan_trigger'"

       set chan_greeting([string tolower $current_chan_name]) [lindex $row 4]
       putlog "Set $current_chan_name ^Bgreeting^B to '$current_chan_greeting'"

       set get_chan_commands [mysql_query "SELECT * FROM bot_commands WHERE command_chan='$current_chan_name'"]
       foreach row2 $get_chan_commands {
              set [lindex $row2 1]([string tolower $current_chan_name]) "[lindex $row2 2]"
              putlog "Set $current_chan_name command ^B[lindex $row2 1]^B to '[lindex $row2 2]'"
       }
}

### MAIN SET FUNCTION ###
proc command:main:set {nick uhost hand chan arg} {


  if {[string tolower [lindex [split $arg] 0]] == "${chan_trigger($chan)}set" && [string tolower [lindex $arg 1]] == "greeting"} {
        if {[isop $nick $chan]} {
                set greeting "[lrange $arg 2 end]"
                putnotc $nick "Set Greeting to '$greeting'"
              } else {
                putnotc $nick "Error(1): You lack access to 'set greeting'"
                putnotc $nick "Error(2): Unable to 'set greeting'"
              }
        } elseif {[string tolower [lindex [split $arg] 0]] == "${chan_trigger($chan)}set" && [string  tolower [lindex $arg 1]] == "trigger"} {
                if {[isop $nick $chan]} {
                        set new_trigger "[lrange $arg 2 end]"
                        set save_trigger [mysql_query "UPDATE bot_channels SET chan_trigger='$new_trigger'"]
                        putnotc $nick "Set channel trigger to '$new_trigger'"
                } else {
                         putnotc $nick "Error(1): You lack access to 'set trigger'"
                        putnotc $nick "Error(2):  Unable to set 'trigger'"
                }
        } elseif {[string tolower [lindex [split $arg] 0]] == "${chan_trigger($chan)}set"} {
                if {[isop $nick $chan]} {
                        set command_input [string tolower [lindex $arg 1]]
                        set command_input_value  "[lrange $arg 2 end]"

                        set result [mysql_query "SELECT command_name FROM bot_commands WHERE command_chan='$chan' && command_name='${command_input}'"]
                                if {[info exist result]} {
                                        foreach row $result {
                                                foreach element $row {
                                                        set update_command [mysql_query "UPDATE bot_commands SET command_value='${command_input_value}'"]
                                                        putnotc $nick "Set $command_input to '$command_input_value'"
                                                    }
                                                }
                                            } else {
                                                set insert_command [mysql_query "INSERT INTO bot_commands (command_chan, command_name, command_value) VALUES ('$chan', '$command_input', '$command_input_value'"]
                                                putnotc $nick "Set $command_input to $command_input_value"
                                            }
                                        } else {
                                            putnotc $nick "Error(1): You lack access to 'set $command_input'"
                                            putnotc $nick "Error(2): Unable to 'set $command_input'"
                                        }
                                    }
                                }

This is a new error I am getting, I completley restarted the bot. I know it has something do with the == "$chan_trigger($chan)" part in the main set proc. I've tried $chan_trigger(${chan}) That didnt really help at all:

[14:33] Tcl error [command:main:set]: can't read "chan_trigger($chan)": no such element in array

De Kus · Post by **De Kus** » Mon May 02, 2005 2:52 pm

you are using global the wrong place. the var outside of the proc is always global, so using global is redudant. you need to use it within the proc command:main:set before used the first time, so you usually you set a global line at the beginning of the proc like:
global chan_trigger global chan_greeting

if that doesnt help:
have you confirmed $current_chan_name contains the chan name without any quotes? I know SQL likes to use single quotes, but TCL uses double quotes or curly bracets.
i mean this behavior:

tcl: evaluate (.tcl): lindex {"1" "2" "3"} 1
Tcl: 2
tcl: evaluate (.tcl): lindex {'1' '2' '3'} 1
Tcl: '2'

I don't know SQL very well, but if you would save as chan_trigger('#channel') and try to load as chan_trigger(#channel) the error would make sense

.

PS: I wouldn't use string tolower, just use this for comparation:
if { [string equal -nocase $a $b] } ...

^DooM^ · Post by **^DooM^** » Mon May 02, 2005 4:18 pm

For adding information into a MySql database you have to enclose it inside '$quotes' So his script is correct on the MySql side.

daltonc · Post by **daltonc** » Mon May 02, 2005 4:45 pm

Ok, I found the problem..
chan_trigger is acting as an array. I have more than one thing set in that array. But is there a way I can make it so it wont act as an array using chan_trigger() ? I want a seprate variable for every chan_trigger($chan). Any ideas?

Post by **Sir_Fz** » Mon May 02, 2005 5:53 pm

What difference does it make ? just put the global line in the appropriate place and it should not cause problems.