no ctcp reply help needed

[CrazyEgg]

I have a little problem.

Last month i had attack with sdbots.after all i saw that looks like a human user(with ident/real name/nick etc.).only one bug have.cause this spam are zombies pc and many of them have version reply.others have and ping reply but noone have time reply(until now).

so what is my problem now.I try to detect onjoin and with a delay of 20 sec version/ping/time.Is the only solution what i have.I try with bind ctcr.
i have response like:
CTCP reply VERSION: mIRC v6.16 Khaled Mardam-Bey from $nick(uhost) to $botnick.

what is the correct to find out the user without version/ping/time reply?
ctcr detect text after CTCP reply VERSION:
i try to find out what means "CTCP reply VERSION:"
Is that an action? notc? msg? ctcp? and if yes what is the correct procedure?

thanks and sorry for my english

[demond]

yes, [bind ctcr] catches CTCP replies (VERSION is one of them)

and no, there is no sure way of recognizing channel user as drone - most dronebots (sdbot definitely) do a pretty good job in disguising as normal mIRC users (you can't catch those by their CTCP replies)

[CrazyEgg]

part of the script:

bind join - * verjoin
bind ctcr - VERSION verreply

proc verjoin {nick uhost hand chan} {
if {((![isbotnick $nick]) && (![isbotnick [hand2nick $hand $chan]]))} {
if {([onchan $nick $chan]) && ("[getchanhost $nick $chan]" == "$uhost") && (![isvoice $nick $chan]) && (![isop $nick $chan])} {
putserv "PRIVMSG $nick :\001VERSION\001"
}
}
}

proc verreply {nick uhost hand dest key arg} {
global botnick
if {[string tolower $nick] != [string tolower $botnick]} {
if {[string match "*VERSION*" [lindex $arg 0]]} {
putlog "user have version"
} else {
putlog "NO version reply."

.................................................................................................
this one is wrong.
how must modify that?
i dont care the version if is mirc,xicr,pirch,xchat,windows chat or anything else.


thanks for your attention

[Sir_Fz]

If the nick replied to a version request then it does have a reply. Something like this should make it clearer for you:

Code: Select all

bind join - * ask:ver
bind ctcr - VERSION get:ver

proc ask:ver {nick uhost hand chan} {
 global askedv
 if {![isbotnick $nick]} {
  puthelp "PRIVMSG $nick :\001VERSION\001"
  set askedv([string tolower $nick]) 1
 }
}

proc get:ver {nick uhost hand dest key arg} {
 global askedv
 if {[info exists askedv([string tolower $nick])]} {
  putlog "$nick has a version reply"
  unset askedv([string tolower $nick])
 }
}

[CrazyEgg]

still not working

Code: Select all

bind join - * ask:ver
bind ctcr - VERSION get:ver

proc ask:ver {nick uhost hand chan} {
 global askedv
 if {![isbotnick $nick]} {
  puthelp "PRIVMSG $nick :\001VERSION\001"
  set askedv([string tolower $nick]) 1
 }
}

proc get:ver {nick uhost hand dest key arg} {
 global askedv
 utimer 5 [list check $nick $uhost $hand $dest $key $arg]
}

proc check {nick uhost hand dest key arg} {
global askedv
if {![info exists askedv([string tolower $nick])]} {
putlog "$nick has NOT a version reply"
unset askedv([string tolower $nick])
} else  {
putlog "$nick has a version reply"
unset askedv([string tolower $nick])
 }
}

i have add a timer for reply.when version exist then everything ok.
when not nothing happend

[demond]

you need to set your timer outside the ctcr handler

[CrazyEgg]

where? cause i tried all possible places and errors like :
can't read "uhost": no such variable
while executing
"list check $nick $uhost $hand $dest $key $arg"
etc.

[demond]

in the proc that issues CTCP VERSION

and 5 seconds is too low, because of the possible lag you should give clients at least 10 seconds to reply

[CrazyEgg]

well i tried like that as you propose

Code: Select all

proc ask:ver {nick uhost hand chan} {
 global askedv
 if {![isbotnick $nick]} {
  puthelp "PRIVMSG $nick :\001VERSION\001"
  set askedv([string tolower $nick]) 1
utimer 5 [list get:ver $nick $uhost $hand $dest $key $arg]
 }
}

the errors and the results:
when the script had version reply :

[21:27:01] <Bot> testingmon joined #
[21:27:03] <Bot> testingmon has a version reply
[21:27:03] <Bot> CTCP reply VERSION: mIRC v6.12 Khaled Mardam-Bey from testingmon to Bot

when the script have no reply the results:
[21:27:22] <Bot> testingmon joined #
[21:27:22] <Bot> Tcl error [ask:ver]: can't read "dest": no such variable

Meaning that: wrong arguments and if you observ the timer does not exist.

[CrazyEgg]

sorry ppl but after what happend on #egghelp i have to say that:

1.thanks the user greenbear for help.Even if the proc doesnt work.
2.Thanks the user rudenstam for his comments like "let's just say that some people arn't supposed to run eggdrops.... and you are one of them"

At last i say another one time.
I want to make a tcl that the results "version reply exist or not exist" can be catched after a 20 sec.

anyone if want to help just help.Nothing more.

Thanks for your attention

p.s. sorry but i didn born knowed tcl language like others.
i am glad to make some ppl "laughing at me on teh forum":)

[rudenstam]

if anyone else is up for 6hours spoonfeeding him

I'm sure you will understand me and greenbear

[greenbear]

Here's the final piece of the code, building on the code Sir_Fz already wrote for you. So now you can stop blaming others because you're a total idiot.

Code: Select all

bind join - * ask:ver
bind ctcr - VERSION get:ver

proc ask:ver {nick uhost hand chan} {
 global askedv
 if {![isbotnick $nick]} {
  puthelp "PRIVMSG $nick :\001VERSION\001"
  set askedv([string tolower $nick]) 1
  utimer 25 [list no:vreply $nick]
 }
}

proc get:ver {nick uhost hand dest key arg} {
 global askedv
 if {[info exists askedv([string tolower $nick])]} {
  putlog "$nick has a version reply"
  unset askedv([string tolower $nick])
 }
}

proc no:vreply {nick} {
 global askedv
 if {[info exists askedv([string tolower $nick])]} {
   putlog "$nick has no version reply"
   unset askedv([string tolower $nick])
 }
}

[CrazyEgg]

i want to thank you a lot for the script and for your comment.
sorry why i have no experiance and try to find solutions but if you search to find out that is the first tcl doing that.
Hope to help and other ppl and not only me and let me be an idiot.

many thanks to: demondand special thanks to Sir_Fz and greenbear.