Bans are set, then immediately removed....

jestrix · Post by **jestrix** » Fri Mar 15, 2002 10:17 pm

OK, after being spammed a bunch of ppl today, I realized my botnet is detecting the floods, banning the people, but then after the ban is set, and (sometimes before the bot can even boot the person), the ban is undone. arrrghhhh! Example:

[18:06] *** ^Fangio sets mode: +b *!*@213-4-20-70.uc.nombres.ttd.es
[18:06] *** l33th4x0r sets mode: -b *!*@213-4-20-70.uc.nombres.ttd.es
[18:06] *** IshwariaR was kicked by SoSt0ned (banned: repeat flood)
[18:06] *** JUSTiSO sets mode: -b *!*@213-4-20-70.uc.nombres.ttd.es
[18:06] *** alkoholic sets mode: -b *!*@213-4-20-70.uc.nombres.ttd.es
[18:06] *** ^Fangio sets mode: +b *!*@213-4-20-70.uc.nombres.ttd.es
[18:06] *** CTCPFlood sets mode: -bb *!*@h31n1fls34o898.telia.com *!*@213-4-20-70.uc.nombres.ttd.es
[18:06] *** SoSt0ned sets mode: -b *!*@213-4-20-70.uc.nombres.ttd.es
[18:06] *** ZooPorn sets mode: -b *!*@213-4-20-70.uc.nombres.ttd.es

I'm running netbots 4.05 (botnetop, chanlimit, mass, netbots, repeat, sentinel, superbitch) on eggie 1.6.8

I have a feeling that the repeat settings set in the conf (and thus in the .chan file) are somehow over-riding the ones in sentinel and repeat.tcl. Is this the case? Any other ideas? The bots all like each other, since if I manually set a ban, it will remain - they won't fight.

Before I change all my confs and chan files, I'd like to see if this is indeed the problem

TIA

--j

Petersen · Post by **Petersen** » Fri Mar 15, 2002 10:41 pm

newchanban is being called without first checking that that ban already exists in the internal banlist. either write the check into the repeat script, or only run it on 1 bot.

jestrix · Post by **jestrix** » Sat Mar 16, 2002 12:28 am

So if I understand you correctly, if newchanban is called when the ban already exists in the channel, the ban is not added, but is instead removed??

Petersen · Post by **Petersen** » Sat Mar 16, 2002 12:44 am

no, its removed and then added. 2 bans cannot exist with the same hostmask in the internal channel banlist. thus newchanban has to delete the old one that already exists with that hostmask in the internal banlist before it can remake it. whats happening in your net is that the flood is triggering a number of bots, but not necessarily all at the same time (ie lag). thus bot1 catches the flood and does newchanban, which is shared to all the other bots. now bot2 sees the flood and runs newchanban, and thus deletes it out of its internal banlist first (sharing the delete to all other bots too), which causes all the bots to send -b (because deleting a ban causes this), and then reapplies it.

jestrix · Post by **jestrix** » Sat Mar 16, 2002 12:50 am

ohhh, that makes sense. Thanks for the further explanation.

Thus, adding in:

if { [isban $ban $chan] != 1} {
newchanban ....
}

should do the trick, correct?

thanks for your help.

Post by **slennox** » Sat Mar 16, 2002 3:14 am

A fix of that type will be implemented in the next repeat.tcl. For sentinel.tcl the ban-related stuff was rewritten completely and doesn't have that issue anymore.

Added an entry to the Issues page for this problem.

jestrix · Post by **jestrix** » Sat Mar 16, 2002 9:42 pm

great, thx for all the input....
I modified repeat.tcl do a simple isban check before the newchanban call, and repeat protection works flawlessly now

NaZguL · Post by **NaZguL** » Tue Mar 19, 2002 10:20 pm

jestrix is that fix working ?
cause i'm using subop6_2.tcl and it have that problem (and its an inssane problem with a 40 bots botnet)

and i dont think there will be a fix for subop.tcl , i dont think its worked on anymore

so is it ?

Yourname · Post by **Yourname** » Wed Mar 20, 2002 12:57 pm

use netbots then