need to change Bad channel bantype.

[honeybee]

Hey guys.
I am using badchan.tcl by bass, and wants to change the default ban type to *!*@host.ip here is the bass code responsible for it.

Code: Select all

proc bmaskhost {uhost} {
  set uhost [lindex [split $uhost !] [expr [llength [split $uhost !]] -1]]
  set temp [string range [lindex [split $uhost @] 0] [expr [string length [lindex [split $uhost @] 0]] - 8] e]
  return "*!*$temp@[lindex [split [maskhost *!*@[lindex [split $uhost @] 1]] @] 1]"
}

proc bc_whois {from key args} {
  global bchan bcqueue bcnicks
#  putlog "319: $args"
  set args [join $args]
  set nick [string tolower [lindex $args 1]]
  if {[info exists bcnicks($nick)]} {set chan $bcnicks($nick)} {return 0}
  set chans [string tolower [lrange $args 2 e]]
  if {[lsearch $bchan(exempt) $chan] == -1 && $bchan(global) != ""} {set bans $bchan(global)} {set bans ""}
  if {[lsearch $bchan(chans) $chan] > -1} {set bans "$bans $bchan($chan)"}
  foreach tok $chans {
    set tok [string trimleft $tok ":@+"]
    foreach ban $bans {
      if {[string match [lindex $ban 0] $tok]} {
        putlog "badchan:  match! $nick k/b'd from $chan because [lrange $ban 1 e]"
        putlog "args: $args, ban: $ban"
        if {[onchan $nick $chan]} {newchanban $chan [bmaskhost [getchanhost $nick $chan]] badchan "[lrange $ban 1 e]" 10}
        return 0
      }
    }
  }
  return 0
}

I changed the code to this:

Code: Select all

proc bmaskhost {uhost} {
  set uhost "*!*@[lindex [split $uhost @] 1]"
  return "$uhost"
}

any other suggestions please.

[krimson]

you splited and got the host.ip part of the uhost correctly, but you could just return it, without writing it to $uhost before

Code: Select all

proc bmaskhost {uhost} {
  return "*!*@[lindex [split $uhost @] 1]"
}

[honeybee]

i guess its faster to set it and then return.

[krimson]

i really don't think you can feel the difference in execution speed with this change :) but why do you want another method of obtaining the ban? you already posted the fastest and simplest way one can use for this task