Script works in shell but not as a proc

[Coixi]

Hello, i've a simple double-foreach script which works nicely when it's runned in shell but when i put it inside proc { }, it won't work anymore.

Here's the script:

Code: Select all

set channels "#chan1 #chan2 #chan3"

set messages "msg1 msg2 msg3"

foreach message $messages {

        foreach channel $channels {

                after 10000 {
                puts "PRIVMSG $message $channel ([clock format [clock seconds] -format %H:%M:%S])"
                set ::pleasewait 1
                }

        vwait ::pleasewait

        }
}

When i start my eggdrop ( v1.6.18 ) it will output this after modules have been loaded:

Code: Select all

PRIVMSG msg1 #chan1 (11:55:44)
PRIVMSG msg1 #chan2 (11:55:54)
PRIVMSG msg1 #chan3 (11:56:04)
PRIVMSG msg2 #chan1 (11:56:14)
PRIVMSG msg2 #chan2 (11:56:24)
PRIVMSG msg2 #chan3 (11:56:34)
PRIVMSG msg3 #chan1 (11:56:44)
PRIVMSG msg3 #chan2 (11:56:54)
PRIVMSG msg3 #chan3 (11:57:04)

After this userfile will be loaded and bot starts normally. The script work as i want it to work but when i want eggdrop to send those messages to channels (make it proc {}), it won't work anymore.

I'm trying it with this code:

Code: Select all

set channels "#chan1 #chan2 #chan3"

set messages "msg1 msg2 msg3"

proc sendmsg {} {
global channels messages

foreach message $messages {

        foreach channel $channels {

                after 10000 {
                puts "PRIVMSG $message $channel ([clock format [clock seconds] -format %H:%M:%S])"
                set ::pleasewait 1
                }

        vwait ::pleasewait

        }
}

}

::sendmsg

But when i start my eggdrop, i'm getting these errors after module loading:

Code: Select all

can't read "message": no such variable
    while executing
"puts "PRIVMSG $message $channel ([clock format [clock seconds] -format %H:%M:%S])""
    ("after" script)
[12:41] Tcl error in file 'coixi.conf':
[12:41] can't wait for variable "::pleasewait":  would wait forever
    while executing
"vwait ::pleasewait"
    (procedure "::sendmsg" line 13)
    invoked from within
"::sendmsg"
    (file "scripts/sendmsg.tcl" line 24)
    invoked from within
"source scripts/sendmsg.tcl"
    (file "coixi.conf" line 1343)
[12:41] * CONFIG FILE NOT LOADED (NOT FOUND, OR ERROR)

I've Googled, i've been going thru these forums and tried those variables with and without global, with/without $ and with :: but i cannot get it work. Also that can't wait for variable "::pleasewait": would wait forever part is bothering me.

If someone could solve or help with this problem, i'd be happyhappyhappy

[Sir_Fz]

Because the variable message is in the proc while the after executes outside the proc; the variable cannot be found. Instead, use the [utimer] eggdrop command.

[Coixi]

Well, i did that but now the script sends the last message of $messages array to last channel in $channels array.

Could you place the utimer in there in a way that it works like with after? Like this:

Code: Select all

PRIVMSG msg1 #chan1 (11:55:44) 
PRIVMSG msg1 #chan2 (11:55:54) 
PRIVMSG msg1 #chan3 (11:56:04) 
PRIVMSG msg2 #chan1 (11:56:14) 
PRIVMSG msg2 #chan2 (11:56:24) 
PRIVMSG msg2 #chan3 (11:56:34) 
PRIVMSG msg3 #chan1 (11:56:44) 
PRIVMSG msg3 #chan2 (11:56:54) 
PRIVMSG msg3 #chan3 (11:57:04)

[Sir_Fz]

Code: Select all

set messages {"msg1" "msg2" "msg3"}
set channels {#chan1 #chan2 #chan3}

proc sendmsg {} {
 global messages channels
 set i 0
 foreach message $messages {
  foreach chan $channels {
   utimer [expr {10*[incr i]}] [list puthelp "PRIVMSG $chan :$message"]
  }
 }
}

sendmsg

[Coixi]

Works like a charm, thanks.

Is utimer/timer best way to keep this whole proc running?

Or would you suggest something else. I want this to run in a loop, when everything is foreached -> it starts again. But i don't know any good way to do so.

[rosc2112]

This format is incorrect for eggdrop (although it may work for tclsh):
puts "PRIVMSG $message $channel ([clock format [clock seconds] -format %H:%M:%S])"

in eggdrop, you'd need to use:

puthelp "PRIVMSG $channel :$message etc"

Note the format of privmsg, the space and the colon are required in the format for irc, refer you to the rfc:

http://www.irchelp.org/irchelp/rfc/chapter4.html
Read section: 4.4.1 Private messages

[Sir_Fz]

Works like a charm, thanks.

Is utimer/timer best way to keep this whole proc running?

Or would you suggest something else. I want this to run in a loop, when everything is foreached -> it starts again. But i don't know any good way to do so.

Call the proc again after the last msg, like this:

Code: Select all

set messages {"msg1" "msg2" "msg3"}
set channels {#chan1 #chan2 #chan3}

proc sendmsg {} {
 global messages channels
 set i 0
 foreach message $messages {
  foreach chan $channels {
   utimer [set t [expr {10*[incr i]}]] [list puthelp "PRIVMSG $chan :$message"]
  }
 }
 utimer $t sendmsg
}

sendmsg

Notice how the delay-time is stored in $t, the proc will restart when the last message is sent.

[Coixi]

Heya,

How do i make sure that those timers won't become duplicate when i .rehash. I've seen a very simple script for that but after two hours of hardcore googling i haven't found it.

It was a if {} with some info_exists stuff but i just cannot find it.

[rosc2112]

Code: Select all

if {![string match "*name_of_timer*" [timers]]} {timer 5 name_of_timer}

the 5 is the number of minutes as an example..

[Sir_Fz]

Read Searching and killing timers.

[demond]

Because the variable message is in the proc while the after executes outside the proc; the variable cannot be found. Instead, use the [utimer] eggdrop command.

there is nothing wrong with using [after] in eggdrop scripts; [utimer] was devised before [after] appeared in Tcl (circa 8.0)

of course, [vwait] usage in eggdrop is a no-no as it blocks

[Sir_Fz]

Didn't say he can't use [after], simply in his case using [utimer] is better since he won't have to worry about changing environments.

[demond]

Didn't say he can't use [after], simply in his case using [utimer] is better since he won't have to worry about changing environments.

actually it's the other way around - [after] is preferable in this case as it allows you to "kill timer" simply by using [after cancel] and there is no need to enumerate timers first and only then do the match & kill