AllProtection.tcl (Stable: v4.8 / Beta: v4.9b4)

[Sir_Fz]

i was tinking the -k was for removing key mode

It is for that, but users like to use it to display the reason of the channel-lock so they use -k to show it.

[AskMe]

I have make a little change on your badchan outpout message...

if {[punishing w:$jn:$c]} {continue}
puthelp "NOTICE $jn :$wm"
lappend offenders $jn
}
putlog "\002AP\002: Warned [join $offenders \002,\002] on $c: $wm"
}

Replace with

if {[punishing w:$jn:$c]} {continue}
puthelp "privmsg $jn :$wm"
lappend offenders $jn
}
putlog "\002AP\002: Warned [join $offenders \002,\002] on $c: $wm"
}

I don't see any choice for the output message "notice" or "privmsg"

the reason why i put privmsg instead of notice is simple... its for detecting spam...

Exemple: many spammer are in #sex so i put the chan in badchan but they only spam when you msg him/her ... when they reply and trigger any spam word the script ban him/her...

I don't know if you have the option to choose for notice or privmsg in your badchan warning message... if not maybe its a good option to add???

ps... sorry for my bad english

[Sir_Fz]

Sure, feature will be added.

[dq]

I'm having a slight issue with the script, it seems when a user activates the proc textl for spamming to much etc, the kick and ban follow through however once the ban time limit is over the ban isn't removed, the error that is printed just after the ban has been made is;

Code: Select all

[08:14] Tcl error [::AllProtection::pubms textl]: wrong # args: should be "timer"

I'm using the latest release (allprotection4.6b7.tcl) and using the latest eggdrop release with a few changes in eggdrop.h but apart from that nothing has been changed, I've only changed the configurable settings and made sure I didn't have any mistakes, no changes to the source code either.

The chaninfo is;

Code: Select all

(00:59:59) (ChanBot) Settings for dynamic channel #channel:
(00:59:59) (ChanBot) Protect modes (chanmode): None
(00:59:59) (ChanBot) Idle Kick after (idle-kick): DON'T!
(01:00:00) (ChanBot) stopnethack: DON'T![code]
(01:00:00) (ChanBot) aop-delay: 0:0
(01:00:00) (ChanBot) revenge-mode: 0
(01:00:00) (ChanBot) ban-time: 0
(01:00:00) (ChanBot) exempt-time: 60
(01:00:00) (ChanBot) invite-time: 60
(01:00:00) (ChanBot) Other modes:
(01:00:00) (ChanBot) -inactive -statuslog -secret -shared
(01:00:00) (ChanBot) -greet -seen -cycle -dontkickops
(01:00:00) (ChanBot) -protectops -protectfriends -revenge -revengebot
(01:00:00) (ChanBot) -bitch -autoop -autovoice -nodesynch
(01:00:00) (ChanBot) -enforcebans -dynamicbans +userbans -autohalfop
(01:00:00) (ChanBot) -protecthalfops
(01:00:00) (ChanBot) -dynamicexempts -userexempts -dynamicinvites -userinvites
(01:00:00) (ChanBot) User defined channel flags:
(01:00:00) (ChanBot) -toys
(01:00:00) (ChanBot) User defined channel settings:
(01:00:00) (ChanBot) regon: 0
(01:00:00) (ChanBot) User defined channel strings:
(01:00:00) (ChanBot) registrar: {}
(01:00:00) (ChanBot) ap:level: 75
(01:00:00) (ChanBot) ap:textl: {2:60 10 kb 2}

(01:00:00) (ChanBot) ap:textc: {0:0 120 kb 2}
(01:00:00) (ChanBot) ap:notcl: {1:1 525948766 kb 2}
(01:00:00) (ChanBot) ap:notcc: {0:0 180 kb 2}
(01:00:00) (ChanBot) ap:caps: {0:0 120 kb 2}
(01:00:00) (ChanBot) ap:repeatl: {0:0 60 k:kb 2}
(01:00:00) (ChanBot) ap:repeatc: {25 30 w:k:kb 2}
(01:00:00) (ChanBot) ap:codes: {r:0 b:0 u:0 c:0 90 kb 2}
(01:00:00) (ChanBot) ap:adv: {- 180 kb 2}
(01:00:00) (ChanBot) ap:antispam: {- + 10 10}
(01:00:00) (ChanBot) ap:swear: {+ 10 kb 2}
(01:00:00) (ChanBot) ap:ctcps: {1:1 525948766 kb 2}
(01:00:00) (ChanBot) ap:massd: {5:1 30 kb 2}
(01:00:00) (ChanBot) ap:massk: {8:2 30 kb 2}
(01:00:00) (ChanBot) ap:massb: {18:2 30 kb 2}
(01:00:00) (ChanBot) ap:limit: 0
(01:00:00) (ChanBot) ap:cjoin: 0:0
(01:00:00) (ChanBot) ap:partmsgs: {0 120 kb 2}
(01:00:00) (ChanBot) ap:partmsgc: {r:0 b:0 u:0 c:0 30 kb 2}
(01:00:00) (ChanBot) ap:revdoor: {0 120 kb 2}
(01:00:00) (ChanBot) ap:nickf: {0:0 60 w:k:kb 2}
(01:00:00) (ChanBot) ap:clones: {0 120 kb 2}
(01:00:00) (ChanBot) ap:bnicks: {- 120 kb 2}
(01:00:00) (ChanBot) ap:drones: {- 180 45 2}
(01:00:00) (ChanBot) ap:bidents: {- 120 kb 2}
(01:00:00) (ChanBot) ap:bchans: {- 90 kb 2 0}
(01:00:00) (ChanBot) ap:echans: {0 60 w:kb 2 0}
(01:00:00) (ChanBot) ap:bctcrs: {- 120 kb 2 0}
(01:00:00) (ChanBot) ap:ctcpchecks: VERSION
(01:00:00) (ChanBot) ap:btextl: {0:0 mR-k lines.flood 60}
(01:00:00) (ChanBot) ap:btextc: {0:0 mR-k chars.flood 60}
(01:00:00) (ChanBot) ap:bnotcl: {0:0 mR-k lines.flood 60}
(01:00:00) (ChanBot) ap:bnotcc: {0:0 mR-k chars.flood 60}
(01:00:00) (ChanBot) ap:bctcp: {0:0 mR-k ctcp.flood 60}
(01:00:00) (ChanBot) ap:massjoin: {0:0 mR-k join.flood 60}
(01:00:00) (ChanBot) ap:brevdoor: {0:0 mR-k revdoor.flood 60}
(01:00:00) (ChanBot) ap:bpartmsg: {0:0 mR-k partmsg.flood 60}
(01:00:00) (ChanBot) ap:bnickf: {0:0 mR-k nick.flood 60}
(01:00:00) (ChanBot) ap:bcodes: {0:0 mR-k codes.flood 60}
(01:00:00) (ChanBot) flood settings: chan ctcp join kick deop nick
(01:00:00) (ChanBot) number: 0 0 0 0 0 0
(01:00:00) (ChanBot) time : 0 0 0 0 0 0[/code]

Am I doing something wrong or not doing something?

[Sir_Fz]

The same procedure is used for kicking and banning for all protections, so if that error occurs for textl then it should occur for all other protections. It would help if you show the output of '.set errorInfo'.

[dq]

I see, well I ran that and this is the result;

Code: Select all

(05:03:23) (ChanBot) Currently: wrong # args: should be "timer"
(05:03:23) (ChanBot) Currently: while executing
(05:03:23) (ChanBot) Currently: "timer $bti [list pushmode $c -b $bm]"
(05:03:23) (ChanBot) Currently: ("foreach" body line 12)
(05:03:23) (ChanBot) Currently: invoked from within
(05:03:23) (ChanBot) Currently: "foreach {jn ju} $nl {
(05:03:23) (ChanBot) Currently: if {[onchan $jn $c] && ![punishing k:$jn:$c]} {
(05:03:23) (ChanBot) Currently: putquick "KICK $c $jn :[clonemap [mapall $km $c $bti] [incr cc]]"
(05:03:23) (ChanBot) Currently: }
(05:03:23) (ChanBot) Currently: if {..."
(05:03:23) (ChanBot) Currently: ("kb" arm line 2)
(05:03:23) (ChanBot) Currently: invoked from within
(05:03:23) (ChanBot) Currently: "switch -- $p {
(05:03:23) (ChanBot) Currently: "kb" {
(05:03:23) (ChanBot) Currently: foreach {jn ju} $nl {
(05:03:23) (ChanBot) Currently: if {[onchan $jn $c] && ![punishing k:$jn:$c]} {
(05:03:23) (ChanBot) Currently: putquick "KICK $c $jn :[clonemap [mapall $km $c..."
(05:03:23) (ChanBot) Currently: (procedure "punish" line 15)
(05:03:23) (ChanBot) Currently: invoked from within
(05:03:23) (ChanBot) Currently: "punish $pm [list $n $u] $c [mapr $myvar(kmsg) "[subst $mapr] in $ts secs"] $myvar(wmsg) $bty $bti $myvar(klmsg) $myvar(ktime) $myvar(ktype) [string to..."
(05:03:23) (ChanBot) Currently: (procedure "checkf" line 5)
(05:03:23) (ChanBot) Currently: invoked from within
(05:03:23) (ChanBot) Currently: "checkf $s $o $uhc $u $c $pm $n $rsn $bty $bti $f $i $myo"
(05:03:23) (ChanBot) Currently: (procedure "seqflood" line 10)
(05:03:23) (ChanBot) Currently: invoked from within
(05:03:23) (ChanBot) Currently: "seqflood $flood $o $s $nick $uhost $chan $pmeth $btype $btime [string length $arg]"
(05:03:23) (ChanBot) Currently: ("textl" arm line 3)
(05:03:23) (ChanBot) Currently: invoked from within
(05:03:23) (ChanBot) Currently: "switch -- $flood {
(05:03:23) (ChanBot) Currently: "textl" - "textc" {
(05:03:23) (ChanBot) Currently: foreach {o s} [cgsplit $off] {break}
(05:03:23) (ChanBot) Currently: seqflood $flood $o $s $nick $uhost $chan $pmeth $btype $btime [str..."
(05:03:23) (ChanBot) Currently: (procedure "::AllProtection::pubms" line 5)
(05:03:23) (ChanBot) Currently: invoked from within
(05:03:23) (ChanBot) Currently: "::AllProtection::pubms textl $_pubm1 $_pubm2 $_pubm3 $_pubm4 $_pubm5"

[Sir_Fz]

Seems to be a problem with your Eggdrop, the [timer] command has been altered. Could be that you have a script which has a procedure called timer and it overrode Eggdrop's [timer] command (perhaps '.tcl info body timer' may return some info about it if it's rewritten).

Edit: After trying to execute [timer] improperly, I got a different error-message than yours:

« Opposing » .tcl timer
« Bot » Tcl error: wrong # args: should be "timer minutes command"
« Opposing » .tcl timer 1
« Bot » Tcl error: wrong # args: should be "timer minutes command"
« Opposing » .tcl timer 1 2 3
« Bot » Tcl error: wrong # args: should be "timer minutes command"

[dq]

Sorry for the late reply, I lost track of time.. yeah you were right another proc was making use of the [timer] command once disabled AP started to work without any issues.

Cheers for such a lengthy script, you've probably made many channel owners very happy with this script, keep up the good work!

[Domin]

Code: Select all

[21:56] ^BAP^B: Warned EpOs on #evy: Warning: You've triggered text flood (chars) protection, decrease your text legnth.
[21:56] Tcl error [::AllProtection::pubms textl]: can't read "offenders": no such variable
[21:56] ^BAP^B: Locked #evy due to Botnet text (chars) flood.

I can't find a reason why this error appeared, however you'll have to show the output of '.set errorInfo' so I can see where exactly the error occurred.

Edit: I took a look at the script and found that this error may indeed occur (after my recent changes to the script). To prevent this error from happening again, replace:

Code: Select all

putlog "\002AP\002: Warned [join $offenders \002,\002] on $c: $wm"

with

Code: Select all

if {[info exists offenders]} { putlog "\002AP\002: Warned [join $offenders \002,\002] on $c: $wm" }

I got the same error now, and i looked in my code but couldt not fine the exact line that you specify here, but i found one that looked very much like it and replaced it whit the one you posted here but now i just get this error:

Code: Select all

[16:47] Tcl error [::AllProtection::pubms textl]: can't read "c": no such variable

The line i replaced looked like this:

Code: Select all

   putlog "\002AP\002: Warned [join $offenders \002,\002] on $chan :$wmsg"

and i replaced it whit the line:

Code: Select all

if {[info exists offenders]} { putlog "\002AP\002: Warned [join $offenders \002,\002] on $c: $wm" }

[Sir_Fz]

You're not using the latest version (v4.6b7), if you want to fix it in the version you're using then replace $c with $chan and $wm with $wmsg. Otherwise download the newer version and apply the changes.

[Domin]

Strange , must have been some sort of cache since i already downloaded the new version after you correctede the error back when it was first reported, but i will just update it, and thanks for the option to fix the older version

[ZEXEL]

what's the lastest version? when it's all release as final version?
thx you all...

[Sir_Fz]

Currently it's v4.6b7. I have no static date for when the final version is to be released, I'm not spending too much time scripting to be honest, but the script is 100% functioning right now as it is... only a few tweaks left and it should be good to be released as final version.

[Domin]

hehe your still missing one nice to have feature, botnet linking, that wouldt be awsome

[ZEXEL]

@Sir_Fz
Can you make all the commands into public/private commands, I mean not use any DCC Chat for it. It think it's great alternative for user that not like use DCC Chat for their bot.

thx again...