string match question

[NewzUK]

Hi - I'm working on a script to retrieve news headlines from a site - I use string match to identify the line in the html that has the info I want.

Normally when I do this, it gets the first line of the match, but in this case it's getting the last line (as there are many) at the bottom of the page...is there any way around this?

Thanks in advance.

[user]

I don't see how this is a string match problem. string match will not tell you where the match is, so the error must be in some other part of your code (obviously).

[NewzUK]

well I've used exactly the same script to get other pages and it's worked, anyway, here is the part I use to get the line:

Code: Select all

    foreach line [split $body \n] {
    if {[string match "*storylink*" $line]} {

and instead of getting the first line 'storylink' is in, it's getting the last. I'm not doing anything else to it except filtering the bits of the line I don't need.

[user]

What do you do inside that 'if'? You should probably 'break' out of the foreach loop

[NewzUK]

Code: Select all

 
   foreach line [split $body \n] {
   if {[string match "*color:blue;\"><b>*" $line]} {
    regexp {<b>(.*)</b>} $line - news
  }
 }
}

I tired putting a break line after the foreach, but then it does nothing

[Sir_Fz]

break exits the loop, you should add the break inside the if-statement since you already found your match in the first line. Of course, add the break after the needed statements inside the if-statement (in your case, after the regexp).

[rosc2112]

Wouldnt it be easier to just use regexp?

Code: Select all

if {[regexp {"*color:blue;"><b>(.*?)</b>"} $body fullmatch mymatch]} {
            # $mymatch has the data you're looking for
} else {
            #putcmdlog "no match"
}