Help to fix errors in script :) [SOLVED]

[TCL_no_TK]

I've wrote down a script a few weeks back, was pretty rough but thought it was simple enough to work found out that its not been working. And after taking the time to go over, haven't been able to fix the following errors:

Tcl error [part:botcover]: missing close-bracket

-- When someone parts the channel.

[08:41:17] <Me> .set errorInfo
[08:41:17] <Bot> [08:44] #Me# set errorInfo
[08:41:18] <Bot> Currently: missing close-bracket
[08:41:18] <Bot> Currently: ("if" test expression)
[08:41:18] <Bot> Currently: while compiling
[08:41:18] <Bot> Currently: "if {($nick != $botnick) && ($nick == [lindex $botcover_cover 0]) || ($nick == [lindex $botcover_cover 1]) && (![botisop $channel) && ([matchattr $botn..."
[08:41:18] <Bot> Currently: (compiling body of proc "part:botcover", line 3)
[08:41:18] <Bot> Currently: invoked from within
[08:41:18] <Bot> Currently: "part:botcover $_p1 $_p2 $_p3 $_p4 $_p5"

-- output of .set errorInfo

The full snipplet is

Code: Select all

set botcover_cover "bot2cover1 bot2cover2"
set botcover_bots "coverbot1 coverbot2"
set botcover_snick "opservice"

proc part:botcover {nick host handle channel {msg ""}} {
global botnick botcover_snick botcover_bots botcover_cover
 if {(![isbotnick $nick]) && ($nick == [lindex $botcover_cover 0]) || ($nick == [lindex $botcover_cover 1]) && (![botisop $channel]) && ([matchattr $botnick |+C $channel])} {
  chattr [lindex $botcover_bots 0] "-|+flov $channel"
   chattr [lindex $botcover_bots 1] "-|+flov $channel"
     putserv "PRIVMSG $botcover_snick :OP $channel $botnick"
      return
 }
}

proc sign:botcover {nick host handle channel reason} {
global botnick botcover_snick botcover_bots botcover_cover
 if {(![isbotnick $nick]) && ($nick == [lindex $botcover_cover 0]) || ($nick == [lindex $botcover_cover 1]) && (![botisop $channel]) && ([matchattr $botnick |+C $channel])} {
  chattr [lindex $botcover_bots 0] "-|+flov $channel"
   chattr [lindex $botcover_bots 1] "-|+flov $channel"
     putserv "PRIVMSG $botcover_snick :OP $channel $botnick"
      return
 }
}

proc splt:botcover {nick host handle channel} {
global botnick botcover_snick botcover_bots botcover_cover
 if {(![isbotnick $nick]) && ($nick == [lindex $botcover_cover 0]) || ($nick == [lindex $botcover_cover 1]) && (![botisop $channel]) && ([matchattr $botnick |+C $channel])} {
  chattr [lindex $botcover_bots 0] "-|+flov $channel"
   chattr [lindex $botcover_bots 1] "-|+flov $channel"
     putserv "PRIVMSG $botcover_snick :OP $channel $botnick"
      return
 }
}

bind splt - "* *" splt:botcover
bind sign - "* *" sign:botcover
bind part - "* *" part:botcover

putlog "loaded botcover.tcl version 1.0.3b"
return

sorry for bother

EDIT: fixed a few errors noted by Users below. Thx

[username]

Look at

Code: Select all

&& (![botisop $channel) &&

You forget ].

[honeybee]

instead of using

Code: Select all

$nick != $botnick

and so on...
why don't you use

Code: Select all

[string equal -nocase $nick $::botnick]

[strikelight]

Maybe because "equal" isn't a valid 'string' argument across all Tcl versions. Just a thought.

[nml375]

Actually, for the special case of testing some nick against bots own nick, use the isbotnick function.

Using "string equal" does have the advantage of offering non-case sensitive matching over simple "string" != "string". True, string equal is not available in older versions of tcl, but then again, I find these older versions (8.0 or older) more and more rare. If this is a concern, add some notice 'bout script requiring tcl 8.2 or newer.

[honeybee]

yeah you hardly find tcl version lower than tcl8.4 on most public shells may be if someone is using their personal box they should update the tcl version for good.

And.. I suggested him string equal function because he has been using "string" == "string" all over his script.

[strikelight]

For those that don't need the bloat of newer eggdrop versions, older eggdrop versions require older Tcl versions (without source code modification). I myself have two separate botnets, one based on 1.1.5, and another based on 1.6.x. But I digress... I didn't want to hijack this thread with this debate, just found it irrelevant a method one chooses to implement something if the result is the same. What is it they say? There's more than one way to skin a cat...

[TCL_no_TK]

Thanks gonna upload it soon and see if it fixes the problems. And maybe look in to getting new glasses

Update: Works great! nice one