Pub string match - simple command, silly problem.

cleaner · Post by **cleaner** » Thu Apr 30, 2009 9:20 am

Hello,

Can anybody help me fix it ?

I don't know what is wrong with this...

I mean that good function "!xxx ccc" show 2 responses:

Code: Select all

15:14:45 <A>  good
15:14:46 <A>  bad

The: "!xxx ccc", as only to show: "good".

Code: Select all

bind pub -|- !xxx pub_do_ccc

proc pub_do_ccc {nick host handle channel text} {


if {[string match -nocase "ccc" [string trim $text]]} {
	putserv "PRIVMSG $channel : good"
}elseif {[string match -nocase "ccc1" [string trim $text]]} {
	putserv "PRIVMSG $channel : good1"
}elseif {[string match -nocase "ccc2" [string trim $text]]} {
	putserv "PRIVMSG $channel : good2"
}
   putserv "PRIVMSG $channel : bad" 

}

tsukeh · Post by **tsukeh** » Thu Apr 30, 2009 9:48 am

Code: Select all

bind pub -|- !xxx pub_do_ccc

proc pub_do_ccc {nick host handle channel text} {
 set text [string trim $text]
 if {[string match -nocase "ccc" $text]} {
   putserv "PRIVMSG $channel : good"
 } elseif {[string match -nocase "ccc1" $text]} {
   putserv "PRIVMSG $channel : good1"
 } elseif {[string match -nocase "ccc2" $text]} {
   putserv "PRIVMSG $channel : good2"
 } else {
   putserv "PRIVMSG $channel : bad"
 }
}

cleaner · Post by **cleaner** » Thu Apr 30, 2009 10:05 am

Thanks

speechles · Post by **speechles** » Thu Apr 30, 2009 5:36 pm

Code: Select all

bind pub -|- !xxx pub_do_ccc

proc pub_do_ccc {nick host handle channel text} {
  switch -- [string tolower [string trim $text]] {
    "ccc" { putserv "PRIVMSG $channel :good" }
    "ccc1" { putserv "PRIVMSG $channel :good1" }
    "ccc2" { putserv "PRIVMSG $channel :good2" }
    default { putserv "PRIVMSG $channel :bad" }
  }
}

There are many ways to accomplish this, but the faster method is usually preferred. The command "switch" is probably faster than nesting if's and else's in this case.

cleaner · Post by **cleaner** » Fri May 01, 2009 11:15 am

Thanks, I think that I most rewrite some scripts hehe

.