remove last ban or a range of last set bans

[simo]

greetingz folks,

we have been using this code for a while now and it works fine removing the last set single ban im wondering how this could be edited to remove either last few set bans or just the single last one that was set :

Code: Select all

bind pub -|- "!rlb" unban:lastbans

proc unban:lastbans {nick uhost hand chan text} {
   global botnick
    if {![isop $nick $chan] && ![ishalfop $nick $chan] && ![matchattr $hand o|o $chan]} { return 0 }
     set chanbanlist [lsort -index 2 -integer -decreasing [chanbans $chan]]
     set last [lindex [lindex $chanbanlist end] 0]
     if {[llength $chanbanlist] > 0} {
     putquick "MODE $chan -b $last"
     return 0
  }
}

for example :

!rlb 4

to remove the last 4 set bans

or :

!rlb

to remove only the single last set ban

[CrazyCat]

Quite easy, you didn't search a lot I guess:

Code: Select all

bind pub -|- "!rlb" unban:lastbans

proc unban:lastbans {nick uhost hand chan text} {
   global botnick
    if {![isop $nick $chan] && ![ishalfop $nick $chan] && ![matchattr $hand o|o $chan]} { return 0 }
     set n [join [lindex $text 0]]
     if {![string is integer -strict $n]} { set n 0 }
     set chanbanlist [lsort -index 2 -integer -decreasing [chanbans $chan]]
     set lasts [lrange $chanbanlist end-$n end]
     foreach last $lasts {
         putquick "MODE $chan -b $last"
     }
  }
}

[simo]

thanks for the reply CrazyCat i tested it and found it sometimes when for example using like:

!rlb 2

it removes 3 instead of 2

[SpiKe^^]

Code: Select all

set lasts [lrange $chanbanlist end-[expr {$n - 1}] end]

[simo]

tried your suggestion as well Spike^^ like this :

Code: Select all

bind pub -|- "!rlb" unban:lastbans

proc unban:lastbans {nick uhost hand chan text} {
   global botnick
    if {![isop $nick $chan] && ![ishalfop $nick $chan] && ![matchattr $hand o|o $chan]} { return 0 }
     set n [join [lindex $text 0]]
     if {![string is integer -strict $n]} { set n 0 }
     set chanbanlist [lsort -index 2 -integer -decreasing [chanbans $chan]]
     set lasts [lrange $chanbanlist end-[expr {$n - 1}] end]
     foreach last $lasts {
       pushmode $chan -b $last
     }
}

when i use like:

!rlb 5


for some reason it removes only 2 while there are 10 bans in the banlist

[simo]

on suggestion of Spike^^ i came up with this wich seems to work but not sure if its proper wiritten :

Code: Select all

bind pub -|- "!rlb" unban:lastbans

proc unban:lastbans {nick uhost hand chan text} {
    if {![isop $nick $chan] && ![ishalfop $nick $chan] && ![matchattr $hand o|o $chan]} { return 0 }
     set n [join [lindex $text 0]]
    if {![string is digit $n]} { putserv "notice $nick :value must be digits only like\: !rlb 3 "  ; return 0 }
     if {![string is integer -strict $n]} { set n 0 }
     set chanbanlist [lsort -index 2 -integer -decreasing [chanbans $chan]]
     set lasts [lrange $chanbanlist end-[expr {$n - 1}] end]
     foreach last $lasts {
       pushmode $chan -b "[lindex $last 0]"  
     }
}

[simo]

the single

!rlb

still doesnt seem to trigger at all tho

from what i understood of the code is it expect a range everytime iic

[simo]

on suggestion of Spike^^ i came up with this :

Code: Select all

bind pub -|- "!rlb" unban:lastbans

proc unban:lastbans {nick uhost hand chan text} {
    if {![isop $nick $chan] && ![ishalfop $nick $chan] && ![matchattr $hand o|o $chan]} { return 0 }
     set n [join [lindex $text 0]]
    if {![string is digit $n]} { putserv "notice $nick :value must be digits only like\: !rlb 3"  ; return 0 }
    if {![string is digit -strict $n] || $n == 0} { set n 1 }
     set chanbanlist [lsort -index 2 -integer -decreasing [chanbans $chan]]
     set lasts [lrange $chanbanlist end-[expr {$n - 1}] end]
     foreach last $lasts {
       pushmode $chan -b "[lindex $last 0]"
     }
}

not sure if its all written proper but it seems to work as expected thanks so far gentz