problem with getops.tcl

[MasterJM]

hi

i have a little botnet only getops.tcl running on the eggs.

one silly problem:

if a person ban and deop 1 eggdrop of these botnet
the remain botnet removes ALL bans from the channel
not only the one of the banned bot ALL bans

this sucks

is it a config problem or is there a chance to improve ist?

the remain botnet may only remove the one ban!

[MasterJM]

a little help log of the partyline:

[23:07] GetOps: Requested Ops from lastline, borgqueen on #diablo2.de.
[23:07] GetOps: MSG from lastline: I don't monitor #diablo2.de.
[23:07] GetOps: MSG from borgqueen: Opped repulse on #diablo2.de.
[23:07] GetOps: Requesting ops from borgqueen on #diablo2.de
[23:07] GetOps: MSG from borgqueen: Opped repulse on #diablo2.de.
[23:08] GetOps: Requesting ops from borgqueen on #diablo2.de
[23:08] GetOps: Requesting unban on #diablo2.de from lastline.
[23:08] GetOps: Requesting unban on #diablo2.de from borgqueen.
[23:08] GetOps: MSG from lastline: I don't monitor #diablo2.de.
[23:08] GetOps: MSG from borgqueen: You are not on #diablo2.de for me.
[23:09] repulse joined #diablo2.de.
[23:09] GetOps: Requested Ops from lastline, borgqueen on #diablo2.de.
[23:09] GetOps: MSG from lastline: I don't monitor #diablo2.de.
[23:09] GetOps: MSG from borgqueen: Opped repulse on #diablo2.de.


this is the problem:

[23:08] GetOps: MSG from borgqueen: You are not on #diablo2.de for me.
[23:09] repulse joined #diablo2.de.


borgqueen not see repulse and removes all bans
this sucks!

[user]

That's called "lag" and, yes, it sucks. Removing all the bans sounds weird though... what ircd are you keeping them on?

EDIT: nm...it seems to be a bug in getops..they're using 'string compare' to check if the bans match

Change line 253 from:

Code: Select all

if {[string compare $nick $ban]} {

to:

Code: Select all

if {[string match [string map {\[ \\\[} $ban] $nick]} {

[MasterJM]

That's called "lag" and, yes, it sucks. Removing all the bans sounds weird though... what ircd are you keeping them on?

yeah

i mean borgqueen knows the mask of repulse - so what is the reason for removing all -

it may only remove the bans matching the mask of repulse


ircd is quakenet - the split and lag net

--
is there a way to fix it?

btw:
repulse is the hub bot 1.6.10
and borgqueen a client 1.6.15

[user]

Please let me know if the suggested fix works

[MasterJM]

Please let me know if the suggested fix works

was line 249 in my getops.tcl (i take the one from my 1.6.15 install)

have changed it - the way you told


yeah i will report
but there is no easy way to test it - so it can take a while *g

thx

[user]

You better make that map {\\ \\\\ \[ \\\[}

[stdragon]

Wouldn't the -nocase option be good?

[user]

Wouldn't the -nocase option be good?

Actually, doing a irc case conversion would be required for it to work completely...if converting to lowercase the chars escaped by my previous map will be gone, so I guess it's not that bad:

Code: Select all

proc irclwr {str} {string tolower [string map {\[ \{ \] \} \\ |} $str]}

if {[string match [irclwr $ban] [irclwr $nick]]} {

[stdragon]

To really be complete, you'd have to parse the 005 numeric reply and get the CASEMAPPING=blah argument hehe. Dalnet, for one, uses plain ascii comparison rather than rfc1459. Maybe eggdrop 1.7 should include ircmatch, ircequal, irclower, ircupper or something along those lines.

[user]

That would be great

[MasterJM]

Please let me know if the suggested fix works

dont work

the botnet even unban banned eggs

banned one bot, this bot ask for unban - but the other bots unban nothing

[user]

dont work

Then you're probably on a non-rfc compliant network. Try without irc case conversion:

Code: Select all

[string match -nocase $ban $nick]

[MasterJM]

the ircd is quakenets asuka ircd

u2.10.11.04+asuka(1.0.3). tiscali.dk.quakenet.org B96AeEFfIKMpSUv

i try i later - busy atm
thx