!say script

[bratt]

hi need help with this script that is intent to make a bot say something in channel by using the trigger !say #chan <text>

the script seems to be bugged or has a mistake because when i do the command it says it to the channel its commanded in rather than the channel its meant to.

the auth part just means the script i have for a user to auth to be able to use the command

Code: Select all

# Says something on any channel
# Usage: !say <chan> <what>
proc pub:say {nick host hand chan arg} {
	global botnick
	if {![auth:check $hand]} {return 0}
	if {[llength $arg] < 2} {
		notice $nick "Usage: !say <chan> <what>"
		return 0
	}
	set thechan [lindex $arg 0]
	set what [lrange $arg 1 end]
	if {![onchan $botnick $thechan]} {
		notice $nick "I'm not on that channel."
		return 0
	}
	puthelp "PRIVMSG $chan :$what"
	notice $nick "Said to $thechan: $what"
	putcmdlog "<<$nick>> !$hand! ($thechan) !say $what"

thanx in advance

[metroid]

Code: Select all

puthelp "PRIVMSG $thechan :$what"

However, it will exploit with braces and brackets.

Use this code instead

Code: Select all

set thechan [lindex [split $arg] 0]
set what [lrange [split $arg] 1 end]

[bratt]

cheers metroid i tried that and it seems to be doing the same

[metroid]

Well it shouldn't.

Maybe you forgot something, here is the fixed code:

Code: Select all

# Says something on any channel
# Usage: !say <chan> <what>
proc pub:say {nick host hand chan arg} {
   global botnick
   if {![auth:check $hand]} {return 0}
   if {[llength $arg] < 2} {
      notice $nick "Usage: !say <chan> <what>"
      return 0
   }
   set thechan [lindex [split $arg] 0]
   set what [lrange [split $arg] 1 end]
   if {![onchan $botnick $thechan]} {
      notice $nick "I'm not on that channel."
      return 0
   }
   puthelp "PRIVMSG $thechan :$what"
   notice $nick "Said to $thechan: $what"
   putcmdlog "<<$nick>> !$hand! ($thechan) !say $what" 

[bratt]

cheers