Question about lists

[XceL]

I need some help with some code. When I use this it just gives me the same results each time, which is:

[21:00] <@********> 0 Files before update.
[21:00] <@********> 3 Files after update.
[21:00] <@********> File database updated succesfully. There were 3 Files added and 0 Files removed.

Code: Select all

proc update {nick uhost hand chan text} {
  set fdb [open /home/xcel/eggdrop/filesys/fs a+]
  set data [read $fdb]
  close $fdb
  set afs 0
  set rfs 0
  set lines [split $data \n]
  putquick "privmsg $chan :[llength $lines] Files before update."
  foreach file [glob /home/xcel/eggdrop/filesys/*.url] {
    if {[lsearch lines $file] == -1} {
      lappend lines $file|[file atime $file]
      incr afs
    }
  }
  putquick "privmsg $chan :[llength $lines] Files after update. $lines"
  set fdb [open /home/xcel/eggdrop/filesys/fs w]
  foreach element $lines {
    puts $fdb "$element"
  }
  close $fdb
  set line1 "File database updated succesfully."
  set line2 "There were $afs Files added and $rfs Files removed."
  putquick "privmsg $chan :$line1 $line2"
}

[demond]

Code: Select all

set fdb [open /home/xcel/eggdrop/filesys/fs a+]

this sets the file pointer after EOF; you need to read from the beginning:

Code: Select all

set fdb [open /home/xcel/eggdrop/filesys/fs r]

also:

Code: Select all

if {[lsearch lines $file] == -1}

should be:

Code: Select all

if {[lsearch $lines $file*] == -1}

[XceL]

Thanks, I had the a+ switch on there for it to create the file at first. Then removed it.

[XceL]

Trying not to clutter up the forums too bad, but this question relates to the script. I have the list of files be inputed into a text file, followed by a carraige return then dcced to the user, if desplayed in notepad why is it a block and not a new line? Thanks, the code to input into the file looks like this.

Code: Select all

      puts $file [join $flist "\n"]

[r0t3n]

i think its to do with notepad's format. Use Wordpad, its alot better.

[^DooM^]

You should not really use wordpad or word for that matter when writing scripts. There are good programs out there which are available to use, some free some not. I Personally use EditPlus 2 to work with TCL / PHP / HTML etc etc and is an awsome client. I do however use Notepad++ which is freeware and open source which you can download from here. This does pretty much exaclty what EditPlus2 does but its free. Trust me when i say once you have used these programs you will never go back to notepad / wordpad ever again

[Sir_Fz]

I personally only like wordpad

[Alchera]

EditPlus 2 is my all time favourite; been using it for at least 4 years now. The document format feature (among many) is excellent.

[demond]

for a complex Tcl project, using a programmer's editor like emacs, with syntax highlighting etc, is a necessity

for a simple eggdrop script (99% of bot scripts would classify in that category), Notepad will suffice

[^DooM^]

EditPlus2 and notepad++ both have syntax hilighting and auto indent features, the list goes on. Great if your not used to or have a linux box to play with emacs