incith:weather (2.8p) (Dec. 18th, 2008)

cache · Post by **cache** » Sun May 10, 2015 3:24 am

speechles wrote:New Version: Incith-weather 2.9d
Http://ereader.kiczek.com/incith-weather.tcl

Thank you very much for keeping this going for many years, I knew you would chime in eventually, I will wait till you finish doing much as you can before I add it, I prefer just the current weather of the day anyway.

speechles · Post by **speechles** » Sun May 10, 2015 6:24 pm

DrJinglesMD wrote:No need to get testy here. We're all here to help.

Your help in this instance was to offer another script? how (un)helpful you are. thanks.

DrJinglesMD wrote:Since the main code in this thread has been updated I removed my code. You could have let those of us know you don't appreciate our help and I'm sure we would have gladly removed it without issue.

So common sense must be taught?

DrJinglesMD wrote:Secondly maybe stop abusing Wunderground by scraping AKA stealing their data and instead use a real API that is made specifically for that?

Oh, but wait.. I am not stealing their data, you must not understand how this script works on behalf of a user. Before you speak about things you do not know. Don't speak.

DrJinglesMD wrote:Don't blame WG because they are trying to protect their assets from people utilizing their service in a way they don't want.

Indeed. Your point was?

DrJinglesMD wrote:If you did that, then none of us would have come in here offering our help.

I don't need to do anything. Nor do you.

DrJinglesMD wrote:Either way, I'm glad the script is being updated and look forward to those updates.

Either way? What other way is there?

The point is, when you post code it should apply to the script at hand, the script/code which is the reason the thread exists.

If your code does not, common sense says, make a new thread to cover your code. Attach appropriate comments and links to the original thread which caused your codes creation saying it broke I am here to fill the void.

Instead, we get what we have here. And it's just so blatantly, appalingly, a clusterf*ck. You get people discussing new scripts with code, that doesn't even belong here. Then they discuss changes to that code and fixes and... ya feel me? The point of the thread is lost, it's now just random pieces of code people have to "string" together and as such becomes a big fat mess.

Not saying it "just to be a dick" either, although the rest of this yeah maybe was to just get upset others are to disrespect my friend, jordan (incith's) work, and just throwing it down and stomping all over it. While I can dust off the footprints, and clean up the clutter most times, this time wunderground is focused solely on money. This is clear by the abundancy of advertising all over (weather.com owns them) the website. So this is not about, a few scripts simulating web-browsers and acting on behalf of single users to get their weather. The same thing will happen at the library on a library pc, it will act just like this script. Now what seperates this script from a web-browser? nothing. There is nothing "bot" about how the script works, other than it only fetches the html. Does not fetch monetizing banner images, or other types. Just the html it seeks out and starts to parse. I take offense that regular expression parsing is illegal.

Now about the API, it requires users to go get their own API token for this script since I shant be sharing my own personal with everybody. This immediately reduces the scripts audience, as it imposes something you must do. So this is a last absolutely last resort. Sorry.

t4uch0r · Post by **t4uch0r** » Mon May 11, 2015 1:58 am

Thanks for the new Version Incith-weather 2.9d.

Somehow the Temperature output is wrong:

weather request; Helsinki, Finland; Local Time: 8:50 AM (May 11, 2015); Updated: 21 seconds ago; Conditions: cld; Temperature: 7.4°F (-13.7°C); Feels-like: 7°F (-13.9°C); High/Low: 59/43°F (15/6.1°C); UV: 1/12; Humidity: 85%; Wind: SSW at 3.0 MPH (4.8 KPH)

The real Temperature was +46 F (+8 C).

speechles · Post by **speechles** » Mon May 11, 2015 3:35 am

That is weird. Wunderground only gives one temperature unit now. So there is logic to make it create the other degree unit.

Code: Select all

if {[string match "*F*" $deg)]} {

It runs the IF statement above and if that matches stores unit as F, and creates C .. ELSE .. it stores unit as C, and creates F. In your case, its reading the wrong degree unit for some reason...

What's weirder is it works for me:

!wz Helsinki, Finland
> speechles's weather request; Helsinki, Finland (60.31999969/24.96999931); Local Time: 10:28 AM (May 11, 2015); Updated: 13 minutes ago; Conditions: cld; Temperature: 48.2°F (8.5°C); Feels-like: 47°F (8.3°C); High/Low: 58/43°F (14.4/6.1°C); UV: 2/12; Humidity: 86%; Wind: West at 3.1 MPH (5.0 KPH)

So not exactly sure what is causing it to miss the unit reading. Does it do this all the time? Can you get on your bots partyline and .console +d then watch what the script sends to debug, and paste that here. Here is what it should look like:

> [00:39] got temperature 48.2 F

Post by **willyw** » Mon May 11, 2015 9:10 am

speechles wrote: ...
Here is what it should look like:
> [00:39] got temperature 48.2 F

I see that in the partyline.

Found this in the script, in the section labeled #TEMPERATURE

Code: Select all

putlog "got temperature $temp $deg"

Left over debugging line?

speechles · Post by **speechles** » Mon May 11, 2015 3:59 pm

willyw wrote:
speechles wrote: ...
Here is what it should look like:
> [00:39] got temperature 48.2 F
I see that in the partyline.

Found this in the script, in the section labeled #TEMPERATURE
Code: Select all
putlog "got temperature $temp $deg"
Left over debugging line?

Not at all. The script isn't finished. Notice as well the #TEMPERATURE part, and all the #SECTIONS below. This was done to ease maintenance in the future. To seperate each function clearly so others can see how this works. The script also saves the entire page it tries to parse in /eggdrop as weather.txt. I can't possibly beta test the script myself, using every possible scenario. These lines (aka debug stuff) let others participate in the problem solving process, which speeds up the time we spend hunting out every issue.

@willyw

weather request; Helsinki, Finland; Local Time: 8:50 AM (May 11, 2015); Updated: 21 seconds ago; Conditions: cld; Temperature: 7.4°F (-13.7°C); Feels-like: 7°F (-13.9°C); High/Low: 59/43°F (15/6.1°C); UV: 1/12; Humidity: 85%; Wind: SSW at 3.0 MPH (4.8 KPH)

The real Temperature was +46 F (+8 C).

It's putting F on the 7.4 when it should be C. If it did that, the real temperature he was giving below would be calculated correctly. This is a good use of debug line since it can show exactly what was captured as the user makes their queries.

Post by **willyw** » Mon May 11, 2015 4:10 pm

speechles wrote: ...
I can't possibly beta test the script myself, using every possible scenario. These lines (aka debug stuff) let others participate in the problem solving process, which speeds up the time we spend hunting out every issue.

Excellent.

Let me know if you have anything in particular that I can do, to help/assist.

rjpearce · Post by **rjpearce** » Wed May 13, 2015 5:41 pm

speechles wrote:New Version: Incith-weather 2.9d
Http://ereader.kiczek.com/incith-weather.tcl

+1 Thank you for keeping this script alive, much appreciated!

Bonnie · Post by **Bonnie** » Wed May 13, 2015 5:50 pm

Thank you for all the work you do to keep the weather script working. I'm non coder but I think I understand the large effort you have to put into this script. Thanks

again.

Bonnie

hellohello · Post by **hellohello** » Thu May 14, 2015 3:16 pm

+1, much thanks for keeping it working!

CP1832 · Post by **CP1832** » Fri May 15, 2015 5:24 pm

speechles wrote:New Version: Incith-weather 2.9d
Http://ereader.kiczek.com/incith-weather.tcl

Awesome work speechles. I'm not all that good in TCL but you should check out wunderground mobile (http://mobile.wunderground.com/cgi-bin/ ... New%20York), which doesn't have any javascript and might be simpler to pull the data from.

a_aa · Post by **a_aa** » Sat May 16, 2015 11:08 am

speechles wrote:That is weird. Wunderground only gives one temperature unit now. So there is logic to make it create the other degree unit.
Code: Select all
if {[string match "*F*" $deg)]} {
It runs the IF statement above and if that matches stores unit as F, and creates C .. ELSE .. it stores unit as C, and creates F. In your case, its reading the wrong degree unit for some reason...

What's weirder is it works for me:
!wz Helsinki, Finland
> speechles's weather request; Helsinki, Finland (60.31999969/24.96999931); Local Time: 10:28 AM (May 11, 2015); Updated: 13 minutes ago; Conditions: cld; Temperature: 48.2°F (8.5°C); Feels-like: 47°F (8.3°C); High/Low: 58/43°F (14.4/6.1°C); UV: 2/12; Humidity: 86%; Wind: West at 3.1 MPH (5.0 KPH)
I too had the exact same issues as t4uch0r. I went through the script and replaced the F with C in the string you referenced, in 3 locations I believe and the issue was fixed.
I would also like to add my "Thank You" to the list of those that have previously done so. Great work keeping it alive.

simboy1234 · Post by **simboy1234** » Sat May 16, 2015 2:09 pm

Thank you all for your support in reviving the script!

a_aa : thanks for the fix.

Cheers.

vigilant · Post by **vigilant** » Thu May 28, 2015 4:35 pm

Hello,

The script is not working.
It gives a wrong temperature reading
high low is unavailable

How can I fix this? Or is the script not in a working state right now?

The temperature is not close to the current temperature.

Hellster · Post by **Hellster** » Fri May 29, 2015 6:59 am

vigilant wrote:Hello,
How can I fix this? Or is the script not in a working state right now?

Please read previous comments by speechles