wont kick nicks with chars like {}

[simo]

i wonder why this wont kick nicks with chars like {} in it

like: {[nick]} [nick]


using this atm:

Code: Select all

bind pub n .k pub:kicker
proc pub:kicker {nick host hand chan text} {
  global botnick

	if {![botisop $chan]} {
		puthelp "NOTICE $nick :I'm not oped on $chan."
		return
	}
	set users [list]
                set reason [join [lrange [split $text "."] 1 end] "."]
	set text  [lindex [split $text "."] 0]
	if {$reason eq ""} { set reason Requested  }
	foreach user $text {

		if {![onchan $user $chan]} {
			putserv "NOTICE $nick $user is not on channel $chan"
		} else {

          lappend users $user

			}
	}
   stackKicks $chan [join $users] $reason 4
}



proc stackKicks {chan kicklist reason {max 4}} {
		set count [llength $kicklist]
		while {$count > 0} {
			if {$count > $max} {
				set users [join [lrange $kicklist 0 [expr {$max - 1}]] ","]
				set kicklist [lrange $kicklist $max end]
				incr count -$max
			} else {
				set users [join $kicklist ","]
				set count 0
			}
			putnow "KICK $chan $users $reason"
		}
	}

it keeps returning nick isnt on channel while he is

[CrazyCat]

Ok, so your script is to answer to ".k aaa bbb ccc.reason of kick" ? (with "aaa", "bbb" and "ccc" as nicks of victims)

Quite strange as syntax, but nevermind...
You do: set text [lindex [split $text "."] 0] and after: foreach user $text {... $text is not a list but an element of list, so it can rarely match an user.
foreach user [split [join $text] " "] might be better imho.

[simo]

thank your for the reply crazycat and yes i use this to have the option of multiple nicks in a kick command and a custom kick reason so to determine the diffence between a nick and the custom kick reason the . comes in place or that was the idea at least

like:

.k nick nick nick nick .some custom reason here

it worked fine untill i was trying to kick nicks with weird chars in them

[simo]

i tried using your suggestion using the foreach user [split [join $text] " "]

but the result is the same it doesnt kick nicks with weird chars in them

Code: Select all

bind pub n .k pub:kicker
proc pub:kicker {nick host hand chan text} {
  global botnick

   if {![botisop $chan]} {
      puthelp "NOTICE $nick :I'm not oped on $chan."
      return
   }
   set users [list]
                set reason [join [lrange [split $text "."] 1 end] "."]
   set text  [lindex [split $text "."] 0]
   if {$reason eq ""} { set reason Requested  }
    foreach user [split [join $text] " "] {
      if {![onchan $user $chan]} {
         putserv "NOTICE $nick $user is not on channel $chan"
      } else {

          lappend users $user

         }
   }
   stackKicks $chan [join $users] $reason 4
}

with chars like {}[] in nick it returned with : {{Tessie}} is not on channel #test

[SpiKe^^]

simo:

Your code is a bit ugly, but try this instead...

Code: Select all

foreach user [split $text] { 

[simo]

Thanks for the reply Spike^^ i would like to see the more proper way of writing this as this is what i have been using so far if this is not proper please show me how its done so i can use that as reference for others i use tnx spike^^

[simo]

i tried adding in the foreach u posted Spike^^

Code: Select all

bind pub n .k pub:kicker
proc pub:kicker {nick host hand chan text} {
  global botnick

   if {![botisop $chan]} {
      puthelp "NOTICE $nick :I'm not oped on $chan."
      return
   }
       set users [list]
       set reason [join [lrange [split $text "."] 1 end] "."]
      set text  [lindex [split $text "."] 0]
   if {$reason eq ""} { set reason Requested  }
		foreach user [split $text] {
           if {![onchan $user $chan]} {
         putserv "NOTICE $nick $user is not on channel $chan"
      } else {
          lappend users $user
         }
   }
   stackKicks $chan [join $users] $reason 4
}

it keeps returning this without showing the nick : is not on channel #test

[willyw]

it keeps returning this without showing the nick : is not on channel #test

Find out exactly what is in $text.

Immediately before this line:

Code: Select all

foreach user [split $text] { 

try something like this:

Code: Select all

putserv "privmsg $chan :text is:    $text "

and then

Code: Select all

putserv "privmsg $chan :split text is:     [split $text] "

Now you're going to see exactly what that foreach command is about to operate on. Perhaps that will hold a clue.

[simo]

thanx willyw i tried that and output is :


the nick is: {[test]}

using .k {[test]}

the putserv "privmsg $chan :text is: $text "
returns : text is: {[test]}

and the putserv "privmsg $chan :split text is: [split $text] "

returns: split text is: {{[test]}}

[simo]

still cant get the nicks with {} in them not sure why it stores them stripped from the {} so when it tries to kick it obviously says not on channel so it must be the storing part that goes wrong im not sure how to store nicks proper with all their chars intact so it can proceed to kick

[willyw]

Something's not right.

Earlier, you'd said:

it keeps returning this without showing the nick : is not on channel #test

I saw that nothing was there, for the value in $user , and posted. The idea was to find out what was in $text, exactly - and hopefully be able to figure out why $user was empty.

That's not happening now.

[simo]

yes the last code i posted doesnt show the actuall nick in the notice of nick not online

[simo]

im stuck cant figure a way to fix this issue i saw im not the first with this issue i saw this old post : http://forum.egghelp.org/viewtopic.php?t=11001
altho this doesnt stack nicks wich is what i was looking for

[CrazyCat]

You have to join the splitted value:

Code: Select all

foreach user [split $text] {
   set user [join $user]
   ....

https://www.tcl.tk/man/tcl8.4/TclCmd/join.htm

[simo]

Thanx crazycat except the thing is i already used split in the set im not sure its a good idea to have duplicate split text